Replace theme() with drupal_render() in image module for theme_image_crop_summary()

WDG (Ukraine,Kharkov) want to implement this on CodeSprintUA.

#4 looks good
if bot happy - i`m happy

#4: drupal_remove_theme_image_module_for_theme_image_crop_summary-2010122-4.patch queued for re-testing.

replace theme() with drupal_render in theme_image_crop_summary().

Patch #9 is wrong. This is the right patch.

Patch in #10 has trailing whitespace.

Fixed whitespace.

Everything ran smoothly with the patch. The crop effect worked properly, and there were no observable errors

+++ b/core/modules/image/image.admin.incundefined
@@ -748,7 +748,14 @@ function theme_image_scale_summary($variables) {
-  return theme('image_resize_summary', $variables);
+  $image_resize_summary = array(
+    '#theme' => 'image_resize_summary',
+    '#data' => array(
+      'width' => $variables['data']['width'],
+      'height' => $variables['data']['height'],
+    ),
+  );
+  return drupal_render($image_resize_summary);

I don't get why this is not...

  $image_resize_summary = array(
    '#theme' => 'image_resize_summary',
    '#variables' => $variables
  );
  return drupal_render($image_resize_summary);

The other changes here look out-of-scope to me.

Let's try this.

#variables won't work, see this code from theme():

  // If a renderable array is passed as $variables, then set $variables to
  // the arguments expected by the theme function.
  if (isset($variables['#theme']) || isset($variables['#theme_wrappers'])) {
    $element = $variables;
    $variables = array();
    if (isset($info['variables'])) {
      foreach (array_keys($info['variables']) as $name) {
        if (isset($element["#$name"])) {
          $variables[$name] = $element["#$name"];
        }
      }
    }
    else {
      $variables[$info['render element']] = $element;
      // Give a hint to render engines to prevent infinite recursion.
      $variables[$info['render element']]['#render_children'] = TRUE;
    }
  }

However this should work:

  $image_resize_summary = array(
    '#theme' => 'image_resize_summary',
    '#data' => $variables['data'],
  );
  return drupal_render($image_resize_summary);

#17: drupal-drupal_render_theme_image_crop_summary-2010122-17.patch queued for re-testing.

#17 looks good to me.

Committed aed78ff and pushed to 8.x. Thanks!