View's more link is sometimes shown even when it is not enabled. Steps to reproduce: install drupal, create two articles, edit frontpage view's items per page to 1 (see "More link: No" setting), goto front page and the more link is shown.

CommentFileSizeAuthor
#18 vdc-2010060-18.patch5.64 KBolli
#18 interdiff.txt768 bytesolli
#15 interdiff.txt936 bytesolli
#15 vdc-2010060-15-fail.patch3.28 KBolli
#15 vdc-2010060-15.patch5.87 KBolli
#12 interdiff.txt924 bytesolli
#12 vdc-2010060-12.patch4.96 KBolli
#8 vdc-2010060-8-fail.patch1.88 KBolli
#8 interdiff.txt3.25 KBolli
#8 vdc-2010060-8.patch4.06 KBolli
#6 vdc-2010060-6.patch1.85 KBdawehner
#1 drupal-2010060-1-fail.patch980 bytesolli
#1 drupal-2010060-1.patch1.85 KBolli
no_more_link.patch913 bytesolli

Comments

olli’s picture

olli commented
Status: Active » Needs review
StatusFileSize
new drupal-2010060-1.patch1.85 KB
new drupal-2010060-1-fail.patch980 bytes
olli’s picture

olli commented
Title: More link is rendered when disabled » More link is rendered when set to "No"
Issue tags: +VDC
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice!!

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -VDC

#1: drupal-2010060-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +VDC

The last submitted patch, drupal-2010060-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new vdc-2010060-6.patch1.85 KB

Just a rerole.

Status: Needs review » Needs work

The last submitted patch, vdc-2010060-6.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new vdc-2010060-8.patch4.06 KB
new interdiff.txt3.25 KB
new vdc-2010060-8-fail.patch1.88 KB

Spotted another one.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, vdc-2010060-8.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review

#8: vdc-2010060-8.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, vdc-2010060-8.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new vdc-2010060-12.patch4.96 KB
new interdiff.txt924 bytes

Looks like that spot makes the lite pager execute count query.

dawehner’s picture

dawehner
Primary language German
commented

Thank you very much, this is looking great now.

Just to be sure it would be cool if you could upload the latest patch without the fixes (just to proove that stuff fail without it).

Status: Needs review » Needs work

The last submitted patch, vdc-2010060-12.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new vdc-2010060-15.patch5.87 KB
new vdc-2010060-15-fail.patch3.28 KB
new interdiff.txt936 bytes

Thanks for the review. Here is a new version and a failing patch. This adds the check for count query to the mini pager test.

damiankloip’s picture

damiankloip commented 
+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayTest.phpundefined
@@ -195,6 +195,36 @@ public function testReadMore() {
+    $this->assertIdentical($view->get_total_rows, NULL, 'The query was not forced to calculate the total number of results.');
+    $this->assertIdentical($view->total_rows, NULL, 'The query did not return the total number of rows.');

These have been added to MiniPagerTest too, which I think is the right place for it. I think we can remove it them from here? Otherwise, looks good to go.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Good point damian!

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt768 bytes
new vdc-2010060-18.patch5.64 KB

Thank you! This fixes #16.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0e0d2f6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.