More link is rendered when set to "No" [#2010060]

Comment	File	Size	Author
#18	vdc-2010060-18.patch	5.64 KB	olli

#18	interdiff.txt	768 bytes	olli
#15	interdiff.txt	936 bytes	olli
#15	vdc-2010060-15-fail.patch	3.28 KB	olli

#15	vdc-2010060-15.patch	5.87 KB	olli

#12	interdiff.txt	924 bytes	olli
#12	vdc-2010060-12.patch	4.96 KB	olli

#8	vdc-2010060-8-fail.patch	1.88 KB	olli

#8	interdiff.txt	3.25 KB	olli
#8	vdc-2010060-8.patch	4.06 KB	olli

#6	vdc-2010060-6.patch	1.85 KB	dawehner

#1	drupal-2010060-1-fail.patch	980 bytes	olli

#1	drupal-2010060-1.patch	1.85 KB	olli

	no_more_link.patch	913 bytes	olli

Comment #1

olli CreditAttribution: olli commented 2 June 2013 at 10:16

Status:

Active

» Needs review

File	Size
drupal-2010060-1.patch	1.85 KB

drupal-2010060-1-fail.patch	980 bytes

Log in or register to post comments

Comment #2

olli CreditAttribution: olli commented 3 June 2013 at 04:18

Title:	More link is rendered when disabled	» More link is rendered when set to "No"
Issue tags:		+VDC

Log in or register to post comments

Comment #3

dawehner

German

CreditAttribution: dawehner commented 3 June 2013 at 05:31

Status:

Needs review

» Reviewed & tested by the community

Nice!!

Log in or register to post comments

Comment #4

catch

he/him

English

CreditAttribution: catch commented 9 June 2013 at 21:17

Issue tags:

-VDC

#1: drupal-2010060-1.patch queued for re-testing.

Log in or register to post comments

Comment #5

9 June 2013 at 21:18

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+VDC

The last submitted patch, drupal-2010060-1.patch, failed testing.

Log in or register to post comments

Comment #6

dawehner

German

CreditAttribution: dawehner commented 9 June 2013 at 21:57

Status:

Needs work

» Needs review

File	Size
vdc-2010060-6.patch	1.85 KB

Just a rerole.

Log in or register to post comments

Comment #7

9 June 2013 at 23:29

Status:

Needs review

» Needs work

The last submitted patch, vdc-2010060-6.patch, failed testing.

Log in or register to post comments

Comment #8

olli CreditAttribution: olli commented 10 June 2013 at 19:23

Status:

Needs work

» Needs review

File	Size
vdc-2010060-8.patch	4.06 KB

interdiff.txt	3.25 KB
vdc-2010060-8-fail.patch	1.88 KB

Spotted another one.

Log in or register to post comments

Comment #9

10 June 2013 at 23:10

Status:	Needs review	» Needs work
Issue tags:	-VDC

The last submitted patch, vdc-2010060-8.patch, failed testing.

Log in or register to post comments

Comment #10

olli CreditAttribution: olli commented 11 June 2013 at 04:09

Status:

Needs work

» Needs review

#8: vdc-2010060-8.patch queued for re-testing.

Log in or register to post comments

Comment #11

11 June 2013 at 05:17

Status:	Needs review	» Needs work
Issue tags:		+VDC

The last submitted patch, vdc-2010060-8.patch, failed testing.

Log in or register to post comments

Comment #12

olli CreditAttribution: olli commented 11 June 2013 at 19:11

Status:

Needs work

» Needs review

File	Size
vdc-2010060-12.patch	4.96 KB

interdiff.txt	924 bytes

Looks like that spot makes the lite pager execute count query.

Log in or register to post comments

Comment #13

dawehner

German

CreditAttribution: dawehner commented 11 June 2013 at 19:57

Thank you very much, this is looking great now.

Just to be sure it would be cool if you could upload the latest patch without the fixes (just to proove that stuff fail without it).

Log in or register to post comments

Comment #14

11 June 2013 at 20:52

Status:

Needs review

» Needs work

The last submitted patch, vdc-2010060-12.patch, failed testing.

Log in or register to post comments

Comment #15

olli CreditAttribution: olli commented 12 June 2013 at 05:10

Status:

Needs work

» Needs review

File	Size
vdc-2010060-15.patch	5.87 KB

vdc-2010060-15-fail.patch	3.28 KB

interdiff.txt	936 bytes

Thanks for the review. Here is a new version and a failing patch. This adds the check for count query to the mini pager test.

Log in or register to post comments

Comment #16

damiankloip CreditAttribution: damiankloip commented 14 June 2013 at 08:07

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayTest.phpundefined
@@ -195,6 +195,36 @@ public function testReadMore() {
+    $this->assertIdentical($view->get_total_rows, NULL, 'The query was not forced to calculate the total number of results.');
+    $this->assertIdentical($view->total_rows, NULL, 'The query did not return the total number of rows.');

These have been added to MiniPagerTest too, which I think is the right place for it. I think we can remove it them from here? Otherwise, looks good to go.