It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().
New version of the patch with added missed drupal_render() functions.
The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-3.patch, failed testing.
+++ b/core/modules/rdf/rdf.moduleundefined @@ -461,7 +461,13 @@ function rdf_process(&$variables, $hook) { + $variable = array( + '#theme' => 'rdf_template_variable_wrapper', + '#content' => $variables[$variable_name], + '#attributes' => $attributes, + '#context' => $context,
https://drupal.org/coding-standards#indenting Indenting errors
Thanks. Indenting errors were solved.
#12 looks good for me if bot green - rtbc
The last submitted patch, drupal_replace_theme_with_drupal_render_rdf_module-2009664-12.patch, failed testing.
Replaced theme with drupal_render
+ '#metadata' => $variables['rdf_metadata_attributes']
missing a trailing comma on this line.
Added trailing comma.
Still no trailing comma in #17
Added a trailing comma and made sure it applies against the latest tree.
The patched worked! After inspecting the element of the submission, the rdf markup there contained normal rdf attributes. In addition the entire submission and appearance of the submission were normal.
Committed 8678e21 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.
Comments
Comment #1
aaronott commentedComment #2
esunger commentedComment #3
esunger commentedNew version of the patch with added missed drupal_render() functions.
Comment #4
esunger commentedComment #5
esunger commentedComment #7
esunger commentedComment #8
esunger commentedComment #9
esunger commentedComment #10
podarokhttps://drupal.org/coding-standards#indenting
Indenting errors
Comment #11
esunger commentedThanks. Indenting errors were solved.
Comment #12
esunger commentedComment #13
podarok#12 looks good for me
if bot green - rtbc
Comment #15
jeroentReplaced theme with drupal_render
Comment #16
thedavidmeister commented+ '#metadata' => $variables['rdf_metadata_attributes']missing a trailing comma on this line.
Comment #17
jeroentAdded trailing comma.
Comment #18
thedavidmeister commented+ '#metadata' => $variables['rdf_metadata_attributes']Still no trailing comma in #17
Comment #19
hussainwebAdded a trailing comma and made sure it applies against the latest tree.
Comment #20
sbudker1 commentedThe patched worked! After inspecting the element of the submission, the rdf markup there contained normal rdf attributes. In addition the entire submission and appearance of the submission were normal.
Comment #21
alexpottCommitted 8678e21 and pushed to 8.x. Thanks!