Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#4 node-drupal_render-2009660-4.patch8.35 KBinternetdevels
#1 node-replace_theme_with_drupal_render-2009660-1.patch9.13 KBjeroent

Comments

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new node-replace_theme_with_drupal_render-2009660-1.patch9.13 KB

Replaced theme with drupal_render in the node module.

Status: Needs review » Needs work

The last submitted patch, node-replace_theme_with_drupal_render-2009660-1.patch, failed testing.

internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

We are working today with this issue during Code Sprint UA.

internetdevels’s picture

internetdevels commented
Assigned: internetdevels » Unassigned
Status: Needs work » Needs review
Issue tags: +CodeSprintUA
StatusFileSize
new node-drupal_render-2009660-4.patch8.35 KB

Patch attached.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

#4 looks nice

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.