Needs a new method on the source controller, e.g. typeLabel().
Node source can display the bundle, entity source should display Entity type / Bundle if it's not the same, i18n can display the object type.
Will also need a views field handler so that we can call the method on that. Or we expose it as an entity property, then you can also access it in rules. That should actually work fine...
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | source-type-2009026-9.patch | 28.21 KB | berdir |
| #9 | source-type-2009026-9-interdiff.txt | 12.61 KB | berdir |
| #7 | source-type-2009026-7.patch | 20.49 KB | berdir |
| #7 | source-type-2009026-7-interdiff.txt | 9.42 KB | berdir |
| #5 | source-type-2009026-1.patch | 12.81 KB | berdir |
Comments
Comment #1
berdirTime to remove that plugin column, can't see it anymore.
This patch implements a view handler and necessary methods and implementations for node (shows bundle e.g. Article, Page, ..), entity (Shows type (bundle), e.g. Content (Article), File (Image)) and i18n string (displays e.g. Node type, Rules config, Menu link).
I think this is quite nice.
I also noticed that the submit display of job items, which is actively used for non-submitted jobs does not currently exist in the export, maybe I forgot to do that when I added it. So that is added too and simplifies the view when it's irrelevant to display progress/changed.
Might triggers some test fails, needs more test coverage and the entity implementation needs more testing and e.g. handling where entity type == bundle.
Comment #3
berdir#1: translatable-node-translation-2011744-2.patch queued for re-testing.
Comment #4
berdirOne thing that is missing is switching the suggestions to use Type as well.
Comment #5
berdirNow with a 100% more correct patch!
Comment #6
cgalli commentedLooks good!
So far the new view structure is only in use when creating a new job.
Managing existing jobs and suggestions still use the prior version.
Comment #7
berdirUpdated the block display of the view, added API tests, let's see if they pass :)
Comment #9
berdirA few kittens had to die during the creation of this patch, but it's for the greater good ;)
Namely, I refactored the i18n source a bit to make it much easier to get the object type from it, by using the item_type for that, instead of a hardcoded 'i18n_string'. That's also a major step towards supporting fields/instances/blocks.
Oh, and fixed the tests :)
Comment #10
cgalli commentedLooks good!
Managing existing jobs as well as suggestions do use the new view.
When opening 'Load Suggestions', the width jumps back to a wider presentation, mainly due to the 'Reason' column (which is cool be itself). On a smaller view port, this will force a break. Is it be possible to limit the max-width of the reason column? But that's only cosmetics.
Comment #11
berdirCommitted and pushed.