Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#9 drupal_remove_theme_datetime-2008986-9.patch897 bytesmarkie
#2 drupal_remove_theme_datetime-2008986-2.patch867 bytesmarkie

Comments

thedavidmeister’s picture

thedavidmeister commented
Issue tags: +Novice
markie’s picture

markie commented
Status: Active » Needs review
StatusFileSize
new drupal_remove_theme_datetime-2008986-2.patch867 bytes

only found one instance in datetime.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, drupal_remove_theme_datetime-2008986-2.patch, failed testing.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Needs review

#2: drupal_remove_theme_datetime-2008986-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, drupal_remove_theme_datetime-2008986-2.patch, failed testing.

thedavidmeister’s picture

thedavidmeister commented

Could we call the array $form_required_marker instead of $array? no idea why the testbots hate this :/

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Needs review

#2: drupal_remove_theme_datetime-2008986-2.patch queued for re-testing.

markie’s picture

markie commented

I'll convert it this afternoon.

markie’s picture

markie commented
StatusFileSize
new drupal_remove_theme_datetime-2008986-9.patch897 bytes

updated.

azinoman’s picture

azinoman commented
Status: Needs review » Reviewed & tested by the community

This patch works well. I tested the date time features on drupal.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f6f0478 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.