Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#11 2006952-2.patch582 byteskay_v
#10 ucfirst.patch582 byteskay_v
#1 2006952-1.patch1.27 KBthedavidmeister

Comments

thedavidmeister’s picture

thedavidmeister commented
Status: Active » Needs review
StatusFileSize
new 2006952-1.patch1.27 KB

patch.

c4rl’s picture

c4rl commented
Title: Replace calls to theme() with renderable arrays in Seven theme » Replace theme() with drupal_render() in seven.theme

Retitling

thedavidmeister’s picture

thedavidmeister commented
Issue tags: +Novice, +Needs manual testing
thedavidmeister’s picture

thedavidmeister commented

this needs manual testing because i refactored things slightly.

Miroling’s picture

Miroling commented
Status: Needs review » Reviewed & tested by the community

Manually tested at Home > Administration > People page. Path tested & working fine.

thedavidmeister’s picture

thedavidmeister commented
Issue tags: -Novice, -Needs manual testing
Miroling’s picture

Miroling commented
Issue tags: +CodeSprintUA

Missed tag for manual testing comment.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Nice tidy up :)

Committed bc7e09a and pushed to 8.x. Thanks!

hass’s picture

hass commented
Status: Fixed » Needs work

Strings need to be ucfirst.

kay_v’s picture

kay_v commented
Assigned: Unassigned » kay_v
Status: Needs work » Needs review
Issue tags: -CodeSprintUA
StatusFileSize
new ucfirst.patch582 bytes

changing strings to ucfirst

kay_v’s picture

kay_v commented
StatusFileSize
new 2006952-2.patch582 bytes

oops - changing patch filename

scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community

Simple string change. Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Committed 6c5cc0c and pushed to 8.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.