Downloading results from node/x/webform-results/download throws the above E_NOTICE if there are no submissions for the webform.

CommentFileSizeAuthor
#3 webform_last_sid-2006740.patch336 bytesquicksketch
#1 webform-E_NOTICE-2006740-1.patch518 bytesrobwilmshurst

Comments

robwilmshurst’s picture

robwilmshurst commented
StatusFileSize
new webform-E_NOTICE-2006740-1.patch518 bytes

Patch attached, however I'm not sure if it makes more sense to define $sid before we iterate through $submissions at line 754.

robwilmshurst’s picture

robwilmshurst commented
Status: Active » Needs review
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new webform_last_sid-2006740.patch336 bytes

Thanks, nice find. I've committed this patch to all branches which just defined $sid with a value of 0.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.