drupal_container() is deprecated, don't use it in bootstrap.php

Nice, but you should probably use the specific methods on the Drupal object for module handler and key/value.

Drupal::moduleHandler()->...
Drupal::keyValue()->...

Reroll with changes from #2, and using Drupal::getContainer() wherever we were needing to return the whole container. It's deprecated, but there's currently no other way.

I will add this task to meta task #2001206: Replace drupal_container() with Drupal::service() as part of same work in other places.

+++ b/core/includes/bootstrap.inc
@@ -1009,7 +1009,7 @@ function drupal_page_is_cacheable($allow_caching = NULL) {
-  $module_handler = drupal_container()->get('module_handler');
+  $module_handler = Drupal::service('module_handler');

Drupal::moduleHandler()

+++ b/core/includes/bootstrap.inc
@@ -1030,8 +1030,8 @@ function bootstrap_invoke_all($hook) {
-  if ($type == 'module' && drupal_container()->get('module_handler')->moduleExists($name)) {
-    return drupal_container()->get('module_handler')->load($name);
+  if ($type == 'module' && Drupal::service('module_handler')->moduleExists($name)) {
+    return Drupal::service('module_handler')->load($name);

$module_handler = Drupal::moduleHandler();
$module_handler->moduleExists()
// etc.

Using Drupal::getContainer() is very discouraged, but in early bootstrap we sometimes don't have another option. We can leave those in here for the time being. If it can get refactored later, that's for later.

#7: bootstrap-2006024-7.patch queued for re-testing.

I am not sure why Drupal installation failed. In this patch I have removed deprecated drupal_container function from bootstrap.inc.

+++ b/core/includes/bootstrap.inc
@@ -759,7 +759,7 @@ function drupal_get_filename($type, $name, $filename = NULL) {
+    if (($container = drupal_getContainer()) && $container->has('keyvalue') && function_exists('db_query')) {

There is no such function. I think you mean Drupal::getContainer().

+++ b/core/includes/bootstrap.inc
@@ -2010,9 +2010,9 @@ function _drupal_bootstrap_configuration() {
+  if (!drupal_getContainer()) {

Ibid.

+++ b/core/includes/bootstrap.inc
@@ -2133,20 +2133,6 @@ function drupal_get_bootstrap_phase() {
-function drupal_container() {
-  return Drupal::getContainer();
-}

We can't remove this yet. Just stop using it.

Why did this patch shrink so much from #3? Did the rest get committed elsewhere?

@Crell - I am not sure where the rest of the code got committed. I ran grep on drupal_container and found only three instances of it in bootstrap.inc file.

huh. Well, OK, as long as it got done. :-)

#14: bootstrap-2006024-14.patch queued for re-testing.

Committed/pushed to 8.x, thanks!