After upgrading to 1.6 the payments are no longer saved as transactions on the individual orders - but the order still goes through.

CommentFileSizeAuthor
#3 quickpay-md5-check-2005422-3.patch345 bytesxen

Comments

lsolesen’s picture

Transaktions-callback MD5 kunne ikke efterprøves. Beregnet MD5: 1xxxx Data: Array ( [msgtype] => authorize [ordernumber] => DCxxx [amount] => 20200 [currency] => DKK [time] => 2013-05-27T19:50:20+00:00 [state] => 1 [qpstat] => 000 [qpstatmsg] => OK [chstat] => 000 [chstatmsg] => OK [merchant] => xxx [merchantemail] => lars@xxx.dk [transaction] => xxx [cardtype] => dankort [cardnumber] => XXXXXXXXXXXXxxxx [cardhash] => [splitpayment] => 1 [acquirer] => nets [fraudprobability] => low [fraudremarks] => [fraudreport] => [fee] => 0 [md5check] => xxxxx )
lsolesen’s picture

And a "Adgang nægtet" on with this message:

quickpay/427/commerce_quickpay/e12ded605d56ffe1748dcb8f8f97ba9e
xen’s picture

Assigned: Unassigned » xen
StatusFileSize
new345 bytes

MD5 check failed. Please try the attached patch.

lsolesen’s picture

Status: Active » Reviewed & tested by the community

Then everything works again, so a new release should probably be rolled :) However, the transactions in quickpay was successful, but they failed to be created in the commerce interface, so the errorhandling might need a little tweaking?

xen’s picture

What went wrong in commerce?

lsolesen’s picture

Well, there was no payment transaction connected to the order. So actually the transaction was created in the quickpay interface, but it failed to created in the commerce backend. The patch, though, now both creates the payment at quickpay and in commerce.

xen’s picture

Status: Reviewed & tested by the community » Fixed

Well, in that case there's not much the error handling can do. If the MD5 check fails, we can't be sure the request was not forged, so we should thoroughly ignore it.

Anyway, the fix has been committed, and a new release will follow shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Added more info.