This a subtask of issue 421118 for a complete history and links to the other subtasks see #421118: [Meta] Standardize capitalization on actions

Lowercase action words are harder to translate. Many contributed modules, like Organic Groups and Views, already use uppercase action words.

To make this task better manageable we decided to split it on a module basis.

Proposed resolution

Change edit to Edit, delete to Delete etc.
Also changed translations to translate (see #1899486: unify dropbutton use of translate/translations wording in links)

CommentFileSizeAuthor
#22 Issue-2004246-by-hass-Standardize-capitalization-on-.patch6.58 KBhass
#15 comment-ops-2004246.13.patch13.53 KBlarowlan
#9 2004246--comment--standardize-capitalization-8.patch6.16 KBnyirocsaba
#6 2004246--comment--standardize-capitalization_1.patch3.48 KBchrishks
#3 comment--standardize-capitalization.png6.94 KBchrishks
#3 comment--standardize-capitalization-admin.png18.56 KBchrishks
#1 2004246--comment--standardize-capitalization.patch2.71 KBchrishks

Comments

chrishks’s picture

chrishks commented
StatusFileSize
new 2004246--comment--standardize-capitalization.patch2.71 KB
chrishks’s picture

chrishks commented
Status: Active » Needs review
chrishks’s picture

chrishks commented
StatusFileSize
new comment--standardize-capitalization-admin.png18.56 KB
new comment--standardize-capitalization.png6.94 KB

Attached screenshots where text is used

chrishks’s picture

chrishks commented

Attached screenshots where text is used

Status: Needs review » Needs work

The last submitted patch, 2004246--comment--standardize-capitalization.patch, failed testing.

chrishks’s picture

chrishks commented
Status: Needs work » Needs review
StatusFileSize
new 2004246--comment--standardize-capitalization_1.patch3.48 KB
hass’s picture

hass commented
Status: Needs review » Reviewed & tested by the community

Thx for working on this.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/comment/comment.admin.incundefined
diff --git a/core/modules/comment/comment.module b/core/modules/comment/comment.module
old mode 100644

Please roll the patch without the file permission changes.

nyirocsaba’s picture

nyirocsaba commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2004246--comment--standardize-capitalization-8.patch6.16 KB
hass’s picture

hass commented
hass’s picture

hass commented
Status: Needs review » Reviewed & tested by the community
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

9: 2004246--comment--standardize-capitalization-8.patch queued for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

9: 2004246--comment--standardize-capitalization-8.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2004246--comment--standardize-capitalization-8.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new comment-ops-2004246.13.patch13.53 KB

No longer applies, reroll

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: comment-ops-2004246.13.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

15: comment-ops-2004246.13.patch queued for re-testing.

hass’s picture

hass commented

Please move the CSS changes to a new case. This case is only about capitalization.

hass’s picture

hass commented

9: 2004246--comment--standardize-capitalization-8.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2004246--comment--standardize-capitalization-8.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new Issue-2004246-by-hass-Standardize-capitalization-on-.patch6.58 KB

Re-roled #9

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Wow, that was a hideous re-roll fail on my behalf, combined a css file from another issue.
Back to RTBC, thanks for cleaning up my mess.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.