I created a new article after fresh Installation.

I tried to edit this first article (click on tab Edit), but some parts of form in overlay are not working right
(screenshot attached).

Everything is right if I go to node edit form through CONTENT/OPERATION EDIT

I think it is a browser compability problem , because in Firefox 21 it works ok.

Files: 
CommentFileSizeAuthor
#24 core-js-domready-IE-2004098-24.patch1.69 KBnod_
PASSED: [[SimpleTest]]: [MySQL] 57,051 pass(es).
[ View ]
#16 drupal-2004098-16.patch1.64 KBelachlan
PASSED: [[SimpleTest]]: [MySQL] 56,724 pass(es).
[ View ]
#15 drupal-2004098-15.patch1.64 KBelachlan
FAILED: [[SimpleTest]]: [MySQL] 56,464 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#13 Capture.PNG54.8 KBelachlan
#3 core-js-domready-IE-2004098-2.patch1.6 KBnod_
PASSED: [[SimpleTest]]: [MySQL] 55,685 pass(es).
[ View ]
d8_overlay_node_form_ie10.JPG159.93 KBMicha1111

Comments

nod_’s picture

What is your javascript console saying?

Micha1111’s picture

Sorry , I don't know, how to do that.

nod_’s picture

Status:Active» Needs review
StatusFileSize
new1.6 KB
PASSED: [[SimpleTest]]: [MySQL] 55,685 pass(es).
[ View ]

ok, it's because of domready. See #1974580-29: Introduce domReady to remove jQuery dependency from drupal.js and clean it up.

The patch updates domready with this pull request https://github.com/ded/domready/pull/17.

nod_’s picture

Issue tags:+JavaScript

Also it's a JS bug so tagging.

aspilicious’s picture

Working fine with the patch. I prefer the library to get updated first, but oh well...

droplet’s picture

Happy to see it :)

nod_’s picture

Status:Needs review» Postponed

let's update the lib first and turn that into an update library X issue.

droplet’s picture

Author said the same word a year ago [ https://github.com/ded/domready/issues/14 ]. Drupalers need to submit a new patch to GITHUB or patch it directly.

catch’s picture

Status:Postponed» Active

Don't understand why this is postponed.

elachlan’s picture

Patch from #3 does not fix the issue.

Furthermore, I had to manually navigate to "/#overlay=node/add/article".

The links without the overlay work. But only if you click the anchor tag, not if you click on the area around it.

elachlan’s picture

Title:Node edit form not working in IE10 for Windows 7 (overlay)» Overlay forms broken in IE10 for Windows 7

I tested a few other overlay forms. All the forms which use this functionality are broken. So you cannot close an overlay form.

droplet’s picture

So you cannot close an overlay form

@see: https://drupal.org/node/2003854#comment-7565911

elachlan’s picture

StatusFileSize
new54.8 KB

Console does not report that error.

I only get the follow error for the front page.

SEC7115: :visited and :link styles can only differ by color. Some styles were not applied to :visited.
drupal

The save and publish button also looks broken.

Also how is "ready.min.js" added the drupal? Shouldn't we add it to a library somewhere?

elachlan’s picture

The above patch applies the js file to
core/misc/domready/ready.min.js

If I look at the html is actually is pointing to
core/assets/vendor/domready/ready.min.js?v=master

elachlan’s picture

Status:Active» Needs review
StatusFileSize
new1.64 KB
FAILED: [[SimpleTest]]: [MySQL] 56,464 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Re-rolled the patch from #3 to the right folder. Looks like it works.

elachlan’s picture

StatusFileSize
new1.64 KB
PASSED: [[SimpleTest]]: [MySQL] 56,724 pass(es).
[ View ]

Changed the actual source instead of using the code supplied by #3.

It looks like the maintainer isn't to active on https://github.com/ded/domready

elachlan’s picture

Issue tags:+Needs manual testing

Adding Tag. Unit testing will not work with this change. Needs to be tested against multiple browsers.

nod_’s picture

Maintainer is active, the pull requests just don't merge properly.
For testing only IE is needed, it doesn't change anything for the other browsers.

elachlan’s picture

I have created a pull request with the changes re-rolled. There are some subtle changes.

https://github.com/ded/domready/pull/21

elachlan’s picture

Information on readystate for further reading. It has being discontinued in IE 11 in favour of onload().

http://msdn.microsoft.com/en-us/library/ie/ms534359(v=vs.85).aspx

nod_’s picture

the page you linked to talks about the script element. not for a page. it does not impact this script functionality.

nod_’s picture

thanks for making the pull request elachlan :) now we just need to wait for the commit.

catch’s picture

Status:Needs review» Postponed

Yep. Postponing on upstream.

nod_’s picture

Status:Postponed» Needs review
StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 57,051 pass(es).
[ View ]
elachlan’s picture

Looks good to me and the patch is green! Good work everyone! :)

catch’s picture

Status:Needs review» Reviewed & tested by the community
catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.