Files: 
CommentFileSizeAuthor
#12 rename_views_method-2003558-12.patch1.72 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 55,632 pass(es). View
#12 interdiff.txt1.48 KBmarlatt
#9 drupal_rename_op_ends-2003558-9.patch1.71 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,826 pass(es). View
#3 Rename_Views_method-2003558-3.patch1.72 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 55,966 pass(es). View
#2 Rename_Views_method-2003558-2.patch1.71 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

NonProfit’s picture

Assigned: Unassigned » NonProfit
NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
1.71 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch created.

marlatt’s picture

Assigned: Unassigned » marlatt
FileSize
1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 55,966 pass(es). View
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php
@@ -53,7 +53,7 @@ function operators() {
-        'method' => 'op_contains',
+        'method' => 'addEndsWith',

It appears that a different method name was replaced than specified.

Replaced specified method name and public assignment.

munizjor’s picture

Status: Needs review » Reviewed & tested by the community

Code (2003558-3.patch) looks good and ran successful test on your patch.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, Rename_Views_method-2003558-3.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#3: Rename_Views_method-2003558-3.patch queued for re-testing.

heddn’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. No mentions of op_ends any more and applies cleanly.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opEndsWith - I'm okay with the with as this is what it does.

nathangervais’s picture

Status: Needs work » Needs review
FileSize
1.71 KB
PASSED: [[SimpleTest]]: [MySQL] 57,826 pass(es). View

Rerolled patch to rename op_ends to opEndsWith.

heddn’s picture

Title: Rename Views method op_ends() to addEndsWith() » Rename Views method op_ends() to opEndsWith()

Fixing title.

dawehner’s picture

Status: Needs review » Needs work

.

marlatt’s picture

FileSize
1.48 KB
1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 55,632 pass(es). View

Revised remaining addEndsWith from #9, and in hopes of saving time changed access method to protected as this appears to be called from inside the class.

marlatt’s picture

Assigned: marlatt » Unassigned
Status: Needs work » Needs review

Changing status..

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Cool. Thank you very much.

webchick’s picture

Title: Rename Views method op_ends() to opEndsWith() » Change notice: Rename Views method op_ends() to opEndsWith()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title: Change notice: Rename Views method op_ends() to opEndsWith() » Rename Views method op_ends() to opEndsWith()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.