Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | rename_views_method-2003558-12.patch | 1.72 KB | marlatt |
| #12 | interdiff.txt | 1.48 KB | marlatt |
| #9 | drupal_rename_op_ends-2003558-9.patch | 1.71 KB | nathangervais |
| #3 | Rename_Views_method-2003558-3.patch | 1.72 KB | marlatt |
| #2 | Rename_Views_method-2003558-2.patch | 1.71 KB | nonprofit |
Comments
Comment #1
nonprofit commentedComment #2
nonprofit commentedPatch created.
Comment #3
marlatt commentedIt appears that a different method name was replaced than specified.
Replaced specified method name and public assignment.
Comment #4
munizjor commentedCode (2003558-3.patch) looks good and ran successful test on your patch.
Comment #6
zschmid commented#3: Rename_Views_method-2003558-3.patch queued for re-testing.
Comment #7
heddnLooks good. No mentions of op_ends any more and applies cleanly.
Comment #8
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opEndsWith - I'm okay with the with as this is what it does.
Comment #9
nathangervais commentedRerolled patch to rename op_ends to opEndsWith.
Comment #10
heddnFixing title.
Comment #11
dawehner.
Comment #12
marlatt commentedRevised remaining addEndsWith from #9, and in hopes of saving time changed access method to protected as this appears to be called from inside the class.
Comment #13
marlatt commentedChanging status..
Comment #14
dawehnerCool. Thank you very much.
Comment #15
webchickCommitted and pushed to 8.x. Thanks!
Moving to the Views queue for the change notice.
Comment #16
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.