Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#13 views-rename_op_contains-2003554-13.patch1.72 KBjeroent
#12 views-rename_op_starts-2003554-12.patch1.68 KBjeroent
#10 views-rename_op_stars-2003554-10.patch1.69 KBjeroent
#9 views-rename_op_contains-2003554-9.patch1.95 KBjeroent
#7 views-rename_op_contains-2003554-7.patch1.71 KBjeroent
#4 views-rename_op_contains_to_addContains-2003554-4.patch1.71 KBjeroent
#2 Rename_Views_method-2003554-2.patch1.7 KBnonprofit

Comments

nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003554-2.patch1.7 KB

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003554-2.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_op_contains_to_addContains-2003554-4.patch1.71 KB

rename method op_contains to addContains.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

rename method op_contains to addContains.

Status: Needs review » Needs work

The last submitted patch, views-rename_op_contains_to_addContains-2003554-4.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_contains-2003554-7.patch1.71 KB

Rename op_contains() to opContains. This is the right one.

dawehner’s picture

dawehner
Primary language German
commented
Title: Rename Views method op_contains() to addContains() » Rename Views method op_contains() to opContains()
Status: Needs review » Needs work

Should be protected

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_contains-2003554-9.patch1.95 KB

Rename op_contains to opContains. Added protected access modifier as mentioned by dawehner.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_op_stars-2003554-10.patch1.69 KB

Wrong patch. Sorry!

dawehner’s picture

dawehner
Primary language German
commented

Nope #9 was the right patch ;)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -96,11 +96,11 @@ function opEqual($expression) {
+  ¶

Ups some whitespace appeared.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_op_starts-2003554-12.patch1.68 KB

Ignore this patch. Sorry!

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_op_contains-2003554-13.patch1.72 KB

This is the right one! :)

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ee9bb51 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.