Files: 
CommentFileSizeAuthor
#4 drupal-op_helper-to-opHelper-2003550-4.patch1.77 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 56,235 pass(es). View
#2 2003550-op_helper-to-addFilter-drupal-2.patch2.15 KBThijsFeryn
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

ThijsFeryn’s picture

Title: Rename Views method op_contains() to addContains() » Rename Views method op_helper() to addFilter()
ThijsFeryn’s picture

Status: Active » Needs review
FileSize
2.15 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Status: Needs review » Needs work

The last submitted patch, 2003550-op_helper-to-addFilter-drupal-2.patch, failed testing.

heddn’s picture

Title: Rename Views method op_helper() to addFilter() » Rename Views method op_helper() to opHelper()
Status: Needs work » Needs review
FileSize
1.77 KB
PASSED: [[SimpleTest]]: [MySQL] 56,235 pass(es). View

Renaming title, re-rolling to rename as opHelper and adding protected per OOP standards.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f584bd9 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.