Files: 
CommentFileSizeAuthor
#12 drupal-viewsRename-op_not-2003548-12.patch2.26 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,340 pass(es). View
#9 drupal_rename_op_not-2003548-9.patch1.73 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 57,622 pass(es). View
#7 drupal_rename_op_not-2003548-7.patch1.73 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
#2 core-op_not_to_camelcase-1856630-2.patch935 bytesGekkoKammen
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

GekkoKammen’s picture

Assigned: Unassigned » GekkoKammen
GekkoKammen’s picture

Assigned: GekkoKammen » Unassigned
Status: Active » Needs review
FileSize
935 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

First attempt at a patch

cam10025’s picture

Assigned: Unassigned » cam10025

Testing

Status: Needs review » Needs work

The last submitted patch, core-op_not_to_camelcase-1856630-2.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
aspilicious’s picture

Status: Needs review » Needs work

Should be "public function addNotLike($field)"

nathangervais’s picture

FileSize
1.73 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Rerolled patch against recent HEAD, including the public scope.

nathangervais’s picture

Status: Needs work » Needs review
nathangervais’s picture

FileSize
1.73 KB
PASSED: [[SimpleTest]]: [MySQL] 57,622 pass(es). View

To be consistent with discussion in https://drupal.org/node/2003582 this latest patch renames the function to opNotLike().

heddn’s picture

Title: Rename Views method op_not() to addNotLike() » Rename Views method op_not() to opNotLike()

Fixing title.

aspilicious’s picture

Status: Needs review » Needs work

Talkes with dawehner about this, should be protected. Srry!

heddn’s picture

FileSize
2.26 KB
PASSED: [[SimpleTest]]: [MySQL] 57,340 pass(es). View

Re-rolling and fixing #11.

heddn’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-viewsRename-op_not-2003548-12.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

thnx!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a7f6b93 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.