Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#12 drupal-viewsRename-op_not-2003548-12.patch2.26 KBheddn
#9 drupal_rename_op_not-2003548-9.patch1.73 KBnathangervais
#7 drupal_rename_op_not-2003548-7.patch1.73 KBnathangervais
#2 core-op_not_to_camelcase-1856630-2.patch935 bytesGekkoKammen

Comments

GekkoKammen’s picture

GekkoKammen commented
Assigned: Unassigned » GekkoKammen
GekkoKammen’s picture

GekkoKammen commented
Assigned: GekkoKammen » Unassigned
Status: Active » Needs review
StatusFileSize
new core-op_not_to_camelcase-1856630-2.patch935 bytes

First attempt at a patch

cam10025’s picture

cam10025 commented
Assigned: Unassigned » cam10025

Testing

Status: Needs review » Needs work

The last submitted patch, core-op_not_to_camelcase-1856630-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

Should be "public function addNotLike($field)"

nathangervais’s picture

nathangervais commented
StatusFileSize
new drupal_rename_op_not-2003548-7.patch1.73 KB

Rerolled patch against recent HEAD, including the public scope.

nathangervais’s picture

nathangervais commented
Status: Needs work » Needs review
nathangervais’s picture

nathangervais commented
StatusFileSize
new drupal_rename_op_not-2003548-9.patch1.73 KB

To be consistent with discussion in https://drupal.org/node/2003582 this latest patch renames the function to opNotLike().

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Rename Views method op_not() to addNotLike() » Rename Views method op_not() to opNotLike()

Fixing title.

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

Talkes with dawehner about this, should be protected. Srry!

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new drupal-viewsRename-op_not-2003548-12.patch2.26 KB

Re-rolling and fixing #11.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-viewsRename-op_not-2003548-12.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#12: drupal-viewsRename-op_not-2003548-12.patch queued for re-testing.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

thnx!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a7f6b93 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.