Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#19 rename_views_method-2003500-19.patch10.06 KBmarlatt
#19 interdiff.txt953 bytesmarlatt
#12 drupal.camelcase_getvaloptions_2003500_12.patch10.07 KBtyjamessmith
#8 2003500_reroll_for_mode.patch10.13 KBtyjamessmith
#5 drupal_views-rename_get_value_options-2003500.patch1.25 MBaviindub

Comments

no_angel’s picture

no_angel commented
Assigned: Unassigned » no_angel

working on at sprint

no_angel’s picture

no_angel commented
Assigned: no_angel » Unassigned
aviindub’s picture

aviindub commented
Assigned: Unassigned » aviindub
aviindub’s picture

aviindub commented

going to attempt this as my first patch

aviindub’s picture

aviindub commented
Status: Active » Needs review
StatusFileSize
new drupal_views-rename_get_value_options-2003500.patch1.25 MB
aviindub’s picture

aviindub commented
Assigned: aviindub » Unassigned
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Needs work

The patch changes file permissions from 644 to 755. It needs a re-roll that does not change permissions. This patch was probably made using Windows. Execute git config --global core.filemode false to fix this.

tyjamessmith’s picture

tyjamessmith commented
Status: Needs work » Needs review
StatusFileSize
new 2003500_reroll_for_mode.patch10.13 KB

Here's the reroll. We did what Xano said. Then just rolled the patch. No other changes.

marlatt’s picture

marlatt commented
Assigned: Unassigned » marlatt
Status: Needs review » Active

Working on this.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: marlatt » Unassigned
Status: Active » Reviewed & tested by the community

Patch changes method names. I confirm that the file modes are now untouched.

marlatt’s picture

marlatt commented
Status: Reviewed & tested by the community » Needs review

Sorry started working same time re-roll was posted.

tyjamessmith’s picture

tyjamessmith commented
StatusFileSize
new drupal.camelcase_getvaloptions_2003500_12.patch10.07 KB

It was mentioned that the functions should have public explicitly expressed so I added it in and rolled the two patches together into this one.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

tyjamessmith’s picture

tyjamessmith commented
Status: Needs work » Needs review

#12: drupal.camelcase_getvaloptions_2003500_12.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review

#12: drupal.camelcase_getvaloptions_2003500_12.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

marlatt’s picture

marlatt commented
Assigned: Unassigned » marlatt
Status: Needs work » Active

Working..

marlatt’s picture

marlatt commented
Assigned: marlatt » Unassigned
Status: Active » Needs review
StatusFileSize
new interdiff.txt953 bytes
new rename_views_method-2003500-19.patch10.06 KB

Removed duplicate public access modifier.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b8f18c3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.