Files: 
CommentFileSizeAuthor
#6 views.core-2003494-rename-get_total_items-2003494-06.patch2.05 KBFredericoT
PASSED: [[SimpleTest]]: [MySQL] 57,238 pass(es).
[ View ]
#2 views.core-2003494-rename-get_total_items-2003494-02.patch2.05 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

toddtomlinson’s picture

Assigned:Unassigned» toddtomlinson
toddtomlinson’s picture

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new2.05 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch attached that renames get_total_items to getTotalItems

jameswoods’s picture

The method renaming code updates look good to me.

Status:Needs review» Needs work

The last submitted patch, views.core-2003494-rename-get_total_items-2003494-02.patch, failed testing.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -126,7 +126,7 @@ function set_current_page($number = NULL) {
+  function getTotalItems() {

Add public access modifier in front of the function to adhere to the new OOP standards.

Fix the above and the patch can be marked RTBC !

FredericoT’s picture

Status:Needs work» Needs review
StatusFileSize
new2.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,238 pass(es).
[ View ]

This issue seems inactive to me so I figured I'd get the ball rolling again.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 33144de and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.