Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views.core-2003494-rename-get_total_items-2003494-06.patch2.05 KBFredericoT
#2 views.core-2003494-rename-get_total_items-2003494-02.patch2.05 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
StatusFileSize
new views.core-2003494-rename-get_total_items-2003494-02.patch2.05 KB

Patch attached that renames get_total_items to getTotalItems

jameswoods’s picture

jameswoods commented

The method renaming code updates look good to me.

Status: Needs review » Needs work

The last submitted patch, views.core-2003494-rename-get_total_items-2003494-02.patch, failed testing.

oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -126,7 +126,7 @@ function set_current_page($number = NULL) {
+  function getTotalItems() {

Add public access modifier in front of the function to adhere to the new OOP standards.

Fix the above and the patch can be marked RTBC !

FredericoT’s picture

FredericoT commented
Status: Needs work » Needs review
StatusFileSize
new views.core-2003494-rename-get_total_items-2003494-06.patch2.05 KB

This issue seems inactive to me so I figured I'd get the ball rolling again.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 33144de and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.