Files: 
CommentFileSizeAuthor
#8 drupal-views-rename-get-table-info-2003472-08.patch1.29 KBFredericoT
PASSED: [[SimpleTest]]: [MySQL] 57,344 pass(es). View
#3 drupal-views-rename-get-table-info-2003472.patch1.28 KBtrevorkjorlien
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

djdevin’s picture

Assigned: Unassigned » djdevin
trevorkjorlien’s picture

Assigned: djdevin » trevorkjorlien

Working on this for DC Portland.

trevorkjorlien’s picture

Assigned: trevorkjorlien » Unassigned
Status: Active » Needs review
FileSize
1.28 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Renamed method "get_table_info()" to "getTableInfo()".

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-views-rename-get-table-info-2003472.patch, failed testing.

djdevin’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, drupal-views-rename-get-table-info-2003472.patch, failed testing.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -707,7 +707,7 @@ function get_join_data($table, $base_table) {
+  function getTableInfo($table) {

Add public access modifier in front of the function to adhere to the new OOP standards.

FredericoT’s picture

Status: Needs work » Needs review
FileSize
1.29 KB
PASSED: [[SimpleTest]]: [MySQL] 57,344 pass(es). View

Looks like this issues is inactive since DC Portland so I'm picking it up.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed df4aac2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.