This is a follow-up issue to #1831894: Users miss "save" button and can't distinguish "editable" and "preview" areas addressing the "Users miss the save button" portion of the previous task. Comment #7 recommended that there be two separate issues.

Pertinent details:

Posted by jessebeach on May 19, 2013 at 4:09pm
xjm, tim.plunkett, dwehner, jessebeach and dmistry discussed and concluded that the Save button will be placed in the bottom left, following the standard Drupal pattern. The save button in the top right will be removed.

#18
Posted by tim.plunkett on May 19, 2013 at 4:18pm
In addition, the Save button will be persistent. Currently it is only visible if the view has been modified.

Files: 
CommentFileSizeAuthor
#3 Screen Shot 2013-05-24 at 8.40.34 PM.png12.1 KBdead_arm
#2 views-2003440-change_location_save_button_style_yes-2.patch1.43 KBiStryker
PASSED: [[SimpleTest]]: [MySQL] 55,710 pass(es).
[ View ]
#2 views-2003440-change_location_save_button_style_no-2.patch1.31 KBiStryker
PASSED: [[SimpleTest]]: [MySQL] 55,864 pass(es).
[ View ]
views-save-default_0.png152.67 KBdead_arm

Comments

iStryker’s picture

Assigned:Unassigned» iStryker

I'll take a crack at this

iStryker’s picture

Assigned:iStryker» Unassigned
Status:Active» Needs review
StatusFileSize
new1.31 KB
PASSED: [[SimpleTest]]: [MySQL] 55,864 pass(es).
[ View ]
new1.43 KB
PASSED: [[SimpleTest]]: [MySQL] 55,710 pass(es).
[ View ]

Attached is 2 patches. One without style and one with a little amount of style. @dead_arm does this need to be styled like the image.

Patch removes actionsElement protected function as it serves no purpose anymore. Before it had 2 purposes. One to put the actions buttons above the display (weight = 0) and the other to hide the button if no changes have been made.

dead_arm’s picture

StatusFileSize
new12.1 KB

@iStryker I asked Jessebeach earlier, and since we are following the Drupal 8 save button pattern by moving it below, we should use the same "big blue" button style styling that is in other places. The png in the issue summary is from the original issue and I think it predates the current save button styling.

Screenshot from node/add/article
Screen Shot 2013-05-24 at 8.40.34 PM.png

dead_arm’s picture

Assigned:Unassigned» dead_arm
Status:Needs review» Postponed

Actually the CSS code is already in place for the primary button to be blue, so there is a bug. Self-assigning this issue to resolve bug. Will follow-up shortly.

dead_arm’s picture

Follow-up issue for the button style regression #2003908: Regression of primary button styling

dead_arm’s picture

Status:Postponed» Needs review
dead_arm’s picture

Status:Needs review» Reviewed & tested by the community

views-2003440-change_location_save_button_style_no-2.patch from #2 moves the buttons, and the button styling will be taken care of in #2003908: Regression of primary button styling

Status:Reviewed & tested by the community» Needs work
Issue tags:-Usability, -sprint, -GoogleUX2012, -VDC, -BADCamp2012UX

The last submitted patch, views-2003440-change_location_save_button_style_no-2.patch, failed testing.

iStryker’s picture

Status:Needs work» Needs review
Issue tags:+Usability, +sprint, +GoogleUX2012, +VDC, +BADCamp2012UX
dead_arm’s picture

Status:Needs review» Reviewed & tested by the community

The second patch of #2 (views-2003440-change_location_save_button_style_no-2.patch) finally got through testing and looks good!

tstoeckler’s picture

Status:Reviewed & tested by the community» Needs review

I'm not sure, as I'm not much of a Views expert, but I assume there is some JS code that currently makes the Save button appear as soon as something has changed. That should be removed. Setting to "needs review" as I'm not really sure.

tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community
+++ b/core/modules/views_ui/lib/Drupal/views_ui/ViewEditFormController.phpundefined
@@ -271,23 +271,6 @@ public function cancel(array $form, array &$form_state) {
-    if (empty($view->changed)) {
-      $element['#attributes'] = array(
-        'class' => array(
-          'js-hide',
-        ),
-      );

That's what this was.

iStryker’s picture

There is JavaScript that toggles the js-hide class. This is still needed for the warning message about the view being change and requires to be saved

tstoeckler’s picture

D'oh, sorry for the noise.

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dead_arm’s picture

Assigned:dead_arm» Unassigned