Rename Views method page_display_options() to pageDisplayOptions() [#2003436]

Comment	File	Size	Author
#14	drupal-viewsRename-page_display_options-2003436-14.patch	4.56 KB	heddn
#10	views-core-pageDisplayOptions-2003436-09.patch	4.42 KB	SpartyDan
#7	views-core-pageDisplayOptions-2003436-07.patch	4.64 KB	SpartyDan
#2	2003436-02-change-page_display_options.patch	4.63 KB	SpartyDan

Comment #1

SpartyDan commented 24 May 2013 at 19:28

I am creating a patch for this.

Log in or register to post comments

Comment #2

SpartyDan commented 24 May 2013 at 19:33

Status:

Active

» Needs review

Status	File	Size
new	2003436-02-change-page_display_options.patch	4.63 KB

Created patch to change page_display_options() to pageDisplayOptions()

*My First Patch*

Log in or register to post comments

Comment #3

25 May 2013 at 01:02

Status:	Needs review	» Needs work
Issue tags:	-Novice, -VDC

The last submitted patch, 2003436-02-change-page_display_options.patch, failed testing.

Log in or register to post comments

Comment #4

SpartyDan commented 25 May 2013 at 05:26

Status:	Needs work	» Needs review
Issue tags:		+Novice, +VDC

#2: 2003436-02-change-page_display_options.patch queued for re-testing.

Log in or register to post comments

Comment #5

oenie commented 27 May 2013 at 18:06

Status:

Needs review

» Reviewed & tested by the community

Looks good to me !

Log in or register to post comments

Comment #6

alexpott

he/they

English

🇪🇺🌍

commented 29 May 2013 at 05:47

Status:

Reviewed & tested by the community

» Needs work

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.phpundefined
@@ -100,10 +100,10 @@ protected function build_form_style(array &$form, array &$form_state, $type) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/wizard/Node.phpundefined
@@ -192,10 +192,10 @@ protected function default_display_filters_user(array $form, array &$form_state)
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

@@ -203,7 +203,7 @@ protected function page_display_options(array $form, array &$form_state) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

This should be {@inheritdoc} instead of Overrides...

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.phpundefined
@@ -111,7 +111,7 @@ protected function page_display_options(array $form, array &$form_state) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

This is actually an unrelated change. As this is the docblock for block_display_options and will probably conflict with the patch that converts that to block_display_options to camelCase