Files: 
CommentFileSizeAuthor
#14 drupal-viewsRename-page_display_options-2003436-14.patch4.56 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,206 pass(es).
[ View ]
#10 views-core-pageDisplayOptions-2003436-09.patch4.42 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-pageDisplayOptions-2003436-09.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#7 views-core-pageDisplayOptions-2003436-07.patch4.64 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] 56,452 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 2003436-02-change-page_display_options.patch4.63 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 55,890 pass(es).
[ View ]

Comments

SpartyDan’s picture

I am creating a patch for this.

SpartyDan’s picture

Status:Active» Needs review
StatusFileSize
new4.63 KB
PASSED: [[SimpleTest]]: [MySQL] 55,890 pass(es).
[ View ]

Created patch to change page_display_options() to pageDisplayOptions()

*My First Patch*

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003436-02-change-page_display_options.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me !

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.phpundefined
@@ -100,10 +100,10 @@ protected function build_form_style(array &$form, array &$form_state, $type) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/wizard/Node.phpundefined
@@ -192,10 +192,10 @@ protected function default_display_filters_user(array $form, array &$form_state)
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

@@ -203,7 +203,7 @@ protected function page_display_options(array $form, array &$form_state) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

This should be {@inheritdoc} instead of Overrides...

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.phpundefined
@@ -111,7 +111,7 @@ protected function page_display_options(array $form, array &$form_state) {
-   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
+   * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::pageDisplayOptions().

This is actually an unrelated change. As this is the docblock for block_display_options and will probably conflict with the patch that converts that to block_display_options to camelCase

SpartyDan’s picture

StatusFileSize
new4.64 KB
FAILED: [[SimpleTest]]: [MySQL] 56,452 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Made changes suggested by #6

Will submit new patch for #2002366: Rename Views method block_display_options() to blockDisplayOptions() to correct 2nd code block in #6

SpartyDan’s picture

Status:Needs work» Needs review
dawehner’s picture

Status:Needs review» Needs work

It should be just {@inheritdoc}, nothing else, sorry.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new4.42 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-pageDisplayOptions-2003436-09.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

@dawehner No worries. Thank you for the help. I understand what is happening now.

patch attached

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-core-pageDisplayOptions-2003436-09.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, views-core-pageDisplayOptions-2003436-09.patch, failed testing.

heddn’s picture

StatusFileSize
new4.56 KB
PASSED: [[SimpleTest]]: [MySQL] 57,206 pass(es).
[ View ]

Let's see if it will apply cleanly now.

heddn’s picture

Status:Needs work» Needs review
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b98a404 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.