Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marthaflour’s picture

Assigned: Unassigned » marthaflour
marthaflour’s picture

Status: Active » Needs review
FileSize
2.29 KB
marthaflour’s picture

Assigned: marthaflour » Unassigned
marthaflour’s picture

uploaded patch. Needs review.

baldwinlouie’s picture

Status: Needs review » Needs work

we're going to need the public access modifier. I made the same mistake in all my patches as well :)

marlatt’s picture

Assigned: Unassigned » marlatt
Status: Needs work » Active

Working...

marlatt’s picture

Assigned: marlatt » Unassigned
Status: Active » Needs review
FileSize
2.31 KB

public prepended to methods.

dawehner’s picture

we're going to need the public access modifier. I made the same mistake in all my patches as well :)

Can you explain why is calling the op methods from outside?

aspilicious’s picture

Status: Needs review » Needs work

Protected it should be , it isn't called from the outside

somepal’s picture

could not find the call to op_between() and to its base method either.

marlatt’s picture

Status: Needs work » Needs review
FileSize
1.88 KB
2.32 KB

Revised method access from public to protected per #9.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Title: Rename Views method op_between() to opBetween() » Change notice: Rename Views method op_between() to opBetween()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title: Change notice: Rename Views method op_between() to opBetween() » Rename Views method op_between() to opBetween()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Postponed
Issue tags: -Needs change record
aspilicious’s picture

Status: Postponed » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.