Files: 
CommentFileSizeAuthor
#11 rename_views_method-2003428-11.patch2.32 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,271 pass(es).
[ View ]
#11 interdiff.txt1.88 KBmarlatt
#7 drupal-Views_Replace_op-between-2003428-7.patch2.31 KBmarlatt
Test request sent.
[ View ]
#2 drupal-Views_Replace_op-between-2003428-2.patch2.29 KBmarthaflour
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

marthaflour’s picture

Assigned:Unassigned» marthaflour
marthaflour’s picture

Status:Active» Needs review
StatusFileSize
new2.29 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
marthaflour’s picture

Assigned:marthaflour» Unassigned
marthaflour’s picture

uploaded patch. Needs review.

baldwinlouie’s picture

Status:Needs review» Needs work

we're going to need the public access modifier. I made the same mistake in all my patches as well :)

marlatt’s picture

Assigned:Unassigned» marlatt
Status:Needs work» Active

Working...

marlatt’s picture

Assigned:marlatt» Unassigned
Status:Active» Needs review
StatusFileSize
new2.31 KB
Test request sent.
[ View ]

public prepended to methods.

dawehner’s picture

we're going to need the public access modifier. I made the same mistake in all my patches as well :)

Can you explain why is calling the op methods from outside?

aspilicious’s picture

Status:Needs review» Needs work

Protected it should be , it isn't called from the outside

somepal’s picture

could not find the call to op_between() and to its base method either.

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new1.88 KB
new2.32 KB
PASSED: [[SimpleTest]]: [MySQL] 56,271 pass(es).
[ View ]

Revised method access from public to protected per #9.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
webchick’s picture

Title:Rename Views method op_between() to opBetween()» Change notice: Rename Views method op_between() to opBetween()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title:Change notice: Rename Views method op_between() to opBetween()» Rename Views method op_between() to opBetween()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Status:Active» Postponed
Issue tags:-Needs change record
aspilicious’s picture

Status:Postponed» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.