Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#11 | rename_views_method-2003428-11.patch | 2.32 KB | marlatt |
#11 | interdiff.txt | 1.88 KB | marlatt |
#7 | drupal-Views_Replace_op-between-2003428-7.patch | 2.31 KB | marlatt |
#2 | drupal-Views_Replace_op-between-2003428-2.patch | 2.29 KB | marthaflour |
Comments
Comment #1
marthaflour CreditAttribution: marthaflour commentedComment #2
marthaflour CreditAttribution: marthaflour commentedComment #3
marthaflour CreditAttribution: marthaflour commentedComment #4
marthaflour CreditAttribution: marthaflour commenteduploaded patch. Needs review.
Comment #5
baldwinlouie CreditAttribution: baldwinlouie commentedwe're going to need the public access modifier. I made the same mistake in all my patches as well :)
Comment #6
marlatt CreditAttribution: marlatt commentedWorking...
Comment #7
marlatt CreditAttribution: marlatt commentedpublic prepended to methods.
Comment #8
dawehnerCan you explain why is calling the op methods from outside?
Comment #9
aspilicious CreditAttribution: aspilicious commentedProtected it should be , it isn't called from the outside
Comment #10
somepal CreditAttribution: somepal commentedcould not find the call to op_between() and to its base method either.
Comment #11
marlatt CreditAttribution: marlatt commentedRevised method access from public to protected per #9.
Comment #12
aspilicious CreditAttribution: aspilicious commentedComment #13
webchickCommitted and pushed to 8.x. Thanks!
Moving to the Views queue for the change notice.
Comment #14
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.
Comment #15
aspilicious CreditAttribution: aspilicious commented