Files: 
CommentFileSizeAuthor
#12 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-12.patch1.75 KBptocheia
PASSED: [[SimpleTest]]: [MySQL] 56,026 pass(es).
[ View ]
#9 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-9.patch1.74 KBptocheia
PASSED: [[SimpleTest]]: [MySQL] 55,893 pass(es).
[ View ]
#7 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch1.88 KBptocheia
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-2.patch1.86 KBlouisjimenez
PASSED: [[SimpleTest]]: [MySQL] 57,694 pass(es).
[ View ]

Comments

louisjimenez’s picture

Issue tags:+Novice, +VDC

I'm working on this at the DrupalCon Portland sprint.

louisjimenez’s picture

Status:Active» Needs review
StatusFileSize
new1.86 KB
PASSED: [[SimpleTest]]: [MySQL] 57,694 pass(es).
[ View ]

Patch attached

Status:Needs review» Needs work
heddn’s picture

Status:Needs work» Needs review
louisjimenez’s picture

dawehner’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -253,7 +253,7 @@ function items_per_page_exposed() {
+  function isOffsetExposed() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -324,14 +324,14 @@ function update_page_info() {
+  function isOffsetExposed() {

Should be a public method.

ptocheia’s picture

Status:Needs work» Needs review
StatusFileSize
new1.88 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Drupal_core-Rename-Views-method-offset_expose-to-isOffsetExposed-2003412-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Public has been added, patch attached.

Status:Needs review» Needs work
ptocheia’s picture

Status:Needs work» Needs review
StatusFileSize
new1.74 KB
PASSED: [[SimpleTest]]: [MySQL] 55,893 pass(es).
[ View ]

OK, trying this again. Sorry, it's my first time trying to patch!

heddn’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

aspilicious’s picture

Status:Reviewed & tested by the community» Needs work

Only used by pager plugins. SHould be protected in stead of public.

ptocheia’s picture

Status:Needs work» Needs review
StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 56,026 pass(es).
[ View ]

Both instances of public changed to protected.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 949f67b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.