Files: 
CommentFileSizeAuthor
#8 views_rename_prepare_filter_select-2003364-8.patch1.69 KBSam Moore
PASSED: [[SimpleTest]]: [MySQL] 55,735 pass(es).
[ View ]
#6 renamefunction-2003364-6.patch1.68 KBSam Moore
PASSED: [[SimpleTest]]: [MySQL] 55,686 pass(es).
[ View ]
#2 renamefunction-2003364-2.patch1.68 KBSam Moore
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Sam Moore’s picture

Assigned:Unassigned» Sam Moore

I'll have a look.

Sam Moore’s picture

Assigned:Sam Moore» Unassigned
Status:Active» Needs review
StatusFileSize
new1.68 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

See patch attached. This has passed local testing on Views Plugins.
Please review.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, renamefunction-2003364-2.patch, failed testing.

Sam Moore’s picture

Status:Needs work» Needs review

#2: renamefunction-2003364-2.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, renamefunction-2003364-2.patch, failed testing.

Sam Moore’s picture

Status:Needs work» Needs review
StatusFileSize
new1.68 KB
PASSED: [[SimpleTest]]: [MySQL] 55,686 pass(es).
[ View ]

See re-uploaded patch attached. This has passed local testing on Views Plugins.
Please review.

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1151,16 +1151,16 @@ function exposed_translate(&$form, $type) {
+  function prepareFilterSelectOptions(&$options) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

All occurences seem to be replaced. The corrected patch should then be RTBC...

Sam Moore’s picture

Status:Needs work» Needs review
StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 55,735 pass(es).
[ View ]

Added "protected" access modifier to method

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed a2b14f1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.