Files: 
CommentFileSizeAuthor
#17 views-core-rename-process-summary-arguments-2003356-17.patch3.97 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,154 pass(es).
[ View ]
#15 views-processSummaryArguments-2003356-15.patch3.92 KBdrupalway
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-processSummaryArguments-2003356-15.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#9 2003356-9.patch3.96 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2003356-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 views-2003356-processSummaryArguments.patch3.97 KBphenaproxima
PASSED: [[SimpleTest]]: [MySQL] 56,810 pass(es).
[ View ]
#2 views-2003356-processSummaryArguments.patch3.94 KBphenaproxima
PASSED: [[SimpleTest]]: [MySQL] 55,874 pass(es).
[ View ]

Comments

phenaproxima’s picture

Assigned:Unassigned» phenaproxima
phenaproxima’s picture

Assigned:phenaproxima» Unassigned
Status:Active» Needs review
StatusFileSize
new3.94 KB
PASSED: [[SimpleTest]]: [MySQL] 55,874 pass(es).
[ View ]

Patch passed all argument and argument validator tests on my localhost...EXCEPT for the date argument handler test. However, that test fails even with the patch not applied, so I think that must be different issue.

elvis2’s picture

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

phenaproxima’s picture

StatusFileSize
new3.97 KB
PASSED: [[SimpleTest]]: [MySQL] 56,810 pass(es).
[ View ]

Added the public modifier to all the functions in the patch.

phenaproxima’s picture

Status:Needs work» Needs review

...and marking as needing review. :)

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me !

oenie’s picture

And thanks elvis2 for helping out ... paying it forward rocks ! :)

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/views-2003356-processSummaryArguments.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4061  100  4061    0     0   7609      0 --:--:-- --:--:-- --:--:-- 11407
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:754
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new3.96 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2003356-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

reroll
conflict

++<<<<<<< HEAD
+      if (isset($this->validator) || $this->validator = $this->getPlugin('argument_validator')) {
+        $this->validator->process_summary_arguments($args);
++=======
+       if (isset($this->validator) || $this->validator = $this->get_plugin('argument_validator')) {
+         $this->validator->processSummaryArguments($args);
++>>>>>>> 4

resolved like this

-      if (isset($this->validator) || $this->validator = $this->get_plugin('argument_validator')) {
+      if (isset($this->validator) || $this->validator = $this->getPlugin('argument_validator')) {
-         $this->validator->process_summary_arguments($args);
+         $this->validator->processSummaryArguments($args);

Status:Needs review» Needs work

The last submitted patch, 2003356-9.patch, failed testing.

elvis2’s picture

Status:Needs work» Needs review
jibran’s picture

Issue tags:-Novice, -VDC

#9: 2003356-9.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 2003356-9.patch, failed testing.

drupalway’s picture

Assigned:Unassigned» drupalway
Issue tags:+CodeSprintUA

We are working today with this issue during Code Sprint UA

drupalway’s picture

Status:Needs work» Needs review
StatusFileSize
new3.92 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-processSummaryArguments-2003356-15.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolled. Please review.

Status:Needs review» Needs work

The last submitted patch, views-processSummaryArguments-2003356-15.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new3.97 KB
PASSED: [[SimpleTest]]: [MySQL] 57,154 pass(es).
[ View ]

Re-rolled

heddn’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

aspilicious’s picture

agree :)

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed da83b1a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.