Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 rename_retrieve_validated_view-2003316-5.patch1.4 KBmariafromatoz
#2 views.core-renamed-retrieve_validated_view-2003316-02.patch1.4 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
StatusFileSize
new views.core-renamed-retrieve_validated_view-2003316-02.patch1.4 KB

Rolled patch to rename retrieve_validated_view - patch attached.

elvis2’s picture

elvis2 commented
Status: Needs review » Reviewed & tested by the community

Reviewed patch based on http://drupal.org/node/1856630#comment-7450696

elvis2’s picture

elvis2 commented

Reviewed patch based on http://drupal.org/node/1856630#comment-7450696

mariafromatoz’s picture

mariafromatoz commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new rename_retrieve_validated_view-2003316-5.patch1.4 KB

Re-roll patch

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename_retrieve_validated_view-2003316-5.patch, failed testing.

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Needs review

#5: rename_retrieve_validated_view-2003316-5.patch queued for re-testing.

mariafromatoz’s picture

mariafromatoz commented
Issue tags: +Novice, +VDC

#5: rename_retrieve_validated_view-2003316-5.patch queued for re-testing.

elvis2’s picture

elvis2 commented

@mari3.14, it looks like your patch is the same as #2. Did you mistakenly roll the patch?

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me !

mariafromatoz’s picture

mariafromatoz commented

Ups, I just learnt to do patches at a sprint last weekend and I thought that the first patch had failed.

elvis2’s picture

elvis2 commented

@mari3.14 no worries. Thanks for working on core...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9b64d30 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.