Rename Views method set_current_page() to setCurrentPage()

I'll take this one.

Issue is ready for review.

All instances of set_current_page() have been updated to the proper convention.

Oops... included the wrong patch. Here's the new one.

Failing tests. Please test and re-roll.

Failing is due to an error on the test server side... Re-testing...

#3: core-rename-set-current-page-2003292-3.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -114,7 +114,7 @@ function get_current_page() {
+  function setCurrentPage($number = NULL) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -249,7 +249,7 @@ public function query() {
+  function setCurrentPage($number = NULL) {

Add public access modifier in front of the function(s) to adhere to the new OOP standards.

All occurences seem to have been replaced.

Re-rolled.

Looks good now.

Needs a re-roll

curl https://drupal.org/files/2003292-9-rename-set_current_page.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3633  100  3633    0     0   3838      0 --:--:-- --:--:-- --:--:--  4693
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:727
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply

Re-rolled based on most recent pull or 8.x branch.

Needs a re-roll

curl https://drupal.org/files/2003292-12-rename-set_current_page.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3632  100  3632    0     0   3964      0 --:--:-- --:--:-- --:--:--  4888
error: patch failed: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php:311
error: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php: patch does not apply

Reroll
Conflict

++<<<<<<< HEAD
 +    $view->pager->set_current_page($rand_number);
 +    $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure getCurrentPage uses the settings of set_current_page.');
++=======
+     $view->pager->setCurrentPage($rand_number);
+     $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure get_current_page uses the settings of set_current_page.');
++>>>>>>> 12

Resolved

-     $view->pager->set_current_page($rand_number);
+     $view->pager->setCurrentPage($rand_number);
 -    $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure get_current_page uses the settings of set_current_page.');
 +

Committed cf23ee6 and pushed to 8.x. Thanks!