Files: 
CommentFileSizeAuthor
#15 2003292-15-rename-set_current_page.patch3.55 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 54,970 pass(es).
[ View ]
#12 2003292-12-rename-set_current_page.patch3.55 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 56,035 pass(es).
[ View ]
#9 2003292-9-rename-set_current_page.patch3.55 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 57,485 pass(es).
[ View ]
#3 core-rename-set-current-page-2003292-3.patch4.23 KBricky.middaugh
PASSED: [[SimpleTest]]: [MySQL] 57,463 pass(es).
[ View ]
#2 core-rename-set-current-page-2003292-2.patch4.23 KBricky.middaugh
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-rename-set-current-page-2003292-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

ricky.middaugh’s picture

Assigned:Unassigned» ricky.middaugh

I'll take this one.

ricky.middaugh’s picture

Status:Active» Needs review
StatusFileSize
new4.23 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-rename-set-current-page-2003292-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Issue is ready for review.

All instances of set_current_page() have been updated to the proper convention.

ricky.middaugh’s picture

StatusFileSize
new4.23 KB
PASSED: [[SimpleTest]]: [MySQL] 57,463 pass(es).
[ View ]

Oops... included the wrong patch. Here's the new one.

Status:Needs review» Needs work

The last submitted patch, core-rename-set-current-page-2003292-3.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

elvis2’s picture

Status:Needs work» Needs review

Failing is due to an error on the test server side... Re-testing...

elvis2’s picture

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -114,7 +114,7 @@ function get_current_page() {
+  function setCurrentPage($number = NULL) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -249,7 +249,7 @@ public function query() {
+  function setCurrentPage($number = NULL) {

Add public access modifier in front of the function(s) to adhere to the new OOP standards.

All occurences seem to have been replaced.

elvis2’s picture

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
PASSED: [[SimpleTest]]: [MySQL] 57,485 pass(es).
[ View ]

Re-rolled.

heddn’s picture

Status:Needs review» Reviewed & tested by the community

Looks good now.

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl https://drupal.org/files/2003292-9-rename-set_current_page.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3633  100  3633    0     0   3838      0 --:--:-- --:--:-- --:--:--  4693
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:727
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
elvis2’s picture

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
PASSED: [[SimpleTest]]: [MySQL] 56,035 pass(es).
[ View ]

Re-rolled based on most recent pull or 8.x branch.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl https://drupal.org/files/2003292-12-rename-set_current_page.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3632  100  3632    0     0   3964      0 --:--:-- --:--:-- --:--:--  4888
error: patch failed: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php:311
error: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
PASSED: [[SimpleTest]]: [MySQL] 54,970 pass(es).
[ View ]

Reroll
Conflict

++<<<<<<< HEAD
+    $view->pager->set_current_page($rand_number);
+    $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure getCurrentPage uses the settings of set_current_page.');
++=======
+     $view->pager->setCurrentPage($rand_number);
+     $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure get_current_page uses the settings of set_current_page.');
++>>>>>>> 12

Resolved

-     $view->pager->set_current_page($rand_number);
+     $view->pager->setCurrentPage($rand_number);
-    $this->assertEqual($view->getCurrentPage(), $rand_number, 'Make sure get_current_page uses the settings of set_current_page.');
+
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed cf23ee6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.