Files: 
CommentFileSizeAuthor
#6 drupal-viewsRename-set_header-2003284-6.patch1.46 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,395 pass(es).
[ View ]
#6 interdiff.txt948 bytesheddn
#2 views-2003284-setHeader.patch611 bytesphenaproxima
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]

Comments

phenaproxima’s picture

Assigned:Unassigned» phenaproxima
phenaproxima’s picture

Assigned:phenaproxima» Unassigned
Status:Active» Needs review
StatusFileSize
new611 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]
phl3tch’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Is this function even needed I can't work out how it will be called?

Maxis’s picture

Issue tags:+CodeSprintUA

I also did not find, but alread exist setHeader here https://api.drupal.org/api/drupal/core!vendor!guzzle!http!Guzzle!Http!Me... etc
may be need rework?

heddn’s picture

Status:Needs work» Needs review
StatusFileSize
new948 bytes
new1.46 KB
PASSED: [[SimpleTest]]: [MySQL] 57,395 pass(es).
[ View ]

I can't see where it is ever used either. Let's try removing it then.

tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

In many cases, "it's not used in core" is not valid. See #2002918-26: Rename Views method get_items() to getItems()

In this case, the last known usage of set_header() was removed in 2007: http://drupalcode.org/project/views.git/commit/582713d

dawehner’s picture

Yeah this seriously does not belong there!

alexpott’s picture

Title:Rename Views method set_header() to setHeader()» Remove Views method set_header()
Status:Reviewed & tested by the community» Fixed

Committed 4d492fe and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.