Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 drupal-viewsRename-set_header-2003284-6.patch1.46 KBheddn
#6 interdiff.txt948 bytesheddn
#2 views-2003284-setHeader.patch611 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
views-2003284-setHeader.patch611 bytes
phl3tch’s picture

phl3tch CreditAttribution: phl3tch commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Is this function even needed I can't work out how it will be called?

Maxis’s picture

Maxis CreditAttribution: Maxis commented
Issue tags: +CodeSprintUA

I also did not find, but alread exist setHeader here https://api.drupal.org/api/drupal/core!vendor!guzzle!http!Guzzle!Http!Me... etc
may be need rework?

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs work » Needs review
FileSize
interdiff.txt948 bytes
drupal-viewsRename-set_header-2003284-6.patch1.46 KB

I can't see where it is ever used either. Let's try removing it then.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

In many cases, "it's not used in core" is not valid. See #2002918-26: Rename Views method get_items() to getItems()

In this case, the last known usage of set_header() was removed in 2007: http://drupalcode.org/project/views.git/commit/582713d

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Yeah this seriously does not belong there!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Rename Views method set_header() to setHeader() » Remove Views method set_header()
Status: Reviewed & tested by the community » Fixed

Committed 4d492fe and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.