Rename Views method get_items() to getItems()

baldwinlouie and I are taking this one.

Here's a patch.

To avoid confusion over the previous patches, i'm rerolling patch #2 with corrections on the acces modifiers for the changed functions.

Re-rolled against 8.x. Might need another re-roll when the advanced_render() change is committed.

Patch attached.

#12: 2002918-rename-get_items.patch queued for re-testing.

:D thnx!

reviewed and checked all the calls. gtg with #12 2002918-rename-get_items.patch

Needs a reroll

curl https://drupal.org/files/2002918-rename-get_items_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2079  100  2079    0     0   2791      0 --:--:-- --:--:-- --:--:--  3640
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1106
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.php:99
error: core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.php: patch does not apply

Re-roll
Conflict

++<<<<<<< HEAD
 +  function get_items($values) {
 +    $field = $this->getValue($values);
++=======
+   protected function getItems($values) {
+     $field = $this->get_value($values);
++>>>>>>> 12

Resolved

-   function get_items($values) {
 -  protected function getItems($values) {
 -    $field = $this->get_value($values);
++  function getItems($values) {
 +    $field = $this->getValue($values);

protected function getItems($values) {

Re-rolled with protected in the PrerenderList.php.

Re-roll.

Perfect

Committed ac6bbe4 and pushed to 8.x. Thanks!

I started porting FullCalendar to D8, and this bit me hard.
I remember adding this method to D7 so contrib could use it.

It very much needs to be public.

Committed a24345a and pushed to 8.x. Thanks!