Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#15 drupal-viewsRename-set_items_per_page-2003282-15.patch4.45 KBheddn
#15 interdiff.txt570 bytesheddn
#10 2003282-rename-set_items_per_page.patch3.77 KBsillygwailo
#7 rename-set-items-per-page-2003282-7.patch3.81 KBtheladebug
#5 rename-set-items-per-page-2003282.patch3.81 KBtheladebug
#2 updated-function-name-2003282.patch3.15 KBtheladebug

Comments

theladebug’s picture

theladebug commented
Assigned: Unassigned » theladebug
theladebug’s picture

theladebug commented
Status: Active » Needs review
StatusFileSize
new updated-function-name-2003282.patch3.15 KB

Status: Needs review » Needs work

The last submitted patch, updated-function-name-2003282.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
theladebug’s picture

theladebug commented
StatusFileSize
new rename-set-items-per-page-2003282.patch3.81 KB

Status: Needs review » Needs work

The last submitted patch, rename-set-items-per-page-2003282.patch, failed testing.

theladebug’s picture

theladebug commented
Status: Needs work » Needs review
StatusFileSize
new rename-set-items-per-page-2003282-7.patch3.81 KB

changed function visibility to public

Status: Needs review » Needs work

The last submitted patch, rename-set-items-per-page-2003282-7.patch, failed testing.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented

This issue is related to #2002920: Rename Views method get_items_per_page() to getItemsPerPage() and that issue should maybe get resolved before this one, where references to get_items_per_page() for this patch are changed to getItemsPerPage() (i.e. a manual merge conflict resolution might be necessary).

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented
Status: Needs work » Needs review
StatusFileSize
new 2003282-rename-set_items_per_page.patch3.77 KB

Here's a re-roll now that #2002920: Rename Views method get_items_per_page() to getItemsPerPage() has been committed.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review

#10: 2003282-rename-set_items_per_page.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

drupee’s picture

drupee commented
Assigned: theladebug » drupee
Status: Needs work » Active
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new interdiff.txt570 bytes
new drupal-viewsRename-set_items_per_page-2003282-15.patch4.45 KB

Switched to public. Let's see if that makes the testbot happy.

drupee’s picture

drupee commented

#15: drupal-viewsRename-set_items_per_page-2003282-15.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

There we go! No other instances left.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b69a5af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.