Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 17:47 UTC
Updated:
29 Jul 2014 at 22:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
markie commentedthree files patched
Comment #2
mcpuddin commentedApplied the patch, tested out views, and nothing broke. I wasn't able to find the exact trigger for this function, but it looked fairly well!
Comment #4
markie commented#1: rename_setWhereGroup-2003270-1.patch queued for re-testing.
Comment #6
heddnFailing tests. Please test and re-roll.
Comment #7
SpartyDan commentedRe-rolled
Comment #9
markie commented#7: views-core-set_where_group-2003270-7.patch queued for re-testing.
Comment #11
markie commentedrerolled against fresh pull.
Comment #13
markie commentedrerolled
Comment #15
markie commented#13: views_rename_setWhereGroup-2003270-12.patch queued for re-testing.
Comment #16
oenie commentedLooks good to me now !
Comment #17
alexpottneeds reroll
Comment #18
jibranreroll
Comment #20
markie commentedre-re-roll
Comment #21
dcam commented#20 looks good to me. All instances of the method name have been rewritten. The method visibility is set to public.
Comment #22
alexpottCommitted 9048d3b and pushed to 8.x. Thanks!