Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#11 views-core-sort_validate-2003242-11.patch989 bytesSpartyDan
#9 views-core-sort_validate-2003242-09.patch976 bytesSpartyDan
#6 2003242-5.patch1.4 KBfarfanfelipe
#3 2003242-3.patch972 bytesmarlatt
#2 2003242-2.patch965 bytesfarfanfelipe

Comments

farfanfelipe’s picture

farfanfelipe commented
Assigned: Unassigned » farfanfelipe
farfanfelipe’s picture

farfanfelipe commented
Status: Active » Needs review
StatusFileSize
new 2003242-2.patch965 bytes

I modified the method and calls to the method.

marlatt’s picture

marlatt commented
StatusFileSize
new 2003242-3.patch972 bytes

Reviewed method, and added public function.

Status: Needs review » Needs work

The last submitted patch, 2003242-3.patch, failed testing.

farfanfelipe’s picture

farfanfelipe commented

I did a clean up for the patch including the 2 and 3 patch modifications.

farfanfelipe’s picture

farfanfelipe commented
StatusFileSize
new 2003242-5.patch1.4 KB
SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review

changed status to needs review so the bot would test the patch in #6

oenie’s picture

oenie commented
Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-sort_validate-2003242-09.patch976 bytes

re-rolled

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Another candidate for protected

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-sort_validate-2003242-11.patch989 bytes

function changed to protected

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ecbeb10 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.