Files: 
CommentFileSizeAuthor
#11 views-core-sort_validate-2003242-11.patch989 bytesSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,872 pass(es).
[ View ]
#9 views-core-sort_validate-2003242-09.patch976 bytesSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 56,052 pass(es).
[ View ]
#6 2003242-5.patch1.4 KBfarfanfelipe
PASSED: [[SimpleTest]]: [MySQL] 55,748 pass(es).
[ View ]
#3 2003242-3.patch972 bytesmarlatt
FAILED: [[SimpleTest]]: [MySQL] 55,735 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 2003242-2.patch965 bytesfarfanfelipe
PASSED: [[SimpleTest]]: [MySQL] 55,730 pass(es).
[ View ]

Comments

farfanfelipe’s picture

Assigned:Unassigned» farfanfelipe
farfanfelipe’s picture

Status:Active» Needs review
StatusFileSize
new965 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,730 pass(es).
[ View ]

I modified the method and calls to the method.

marlatt’s picture

StatusFileSize
new972 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,735 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Reviewed method, and added public function.

Status:Needs review» Needs work

The last submitted patch, 2003242-3.patch, failed testing.

farfanfelipe’s picture

I did a clean up for the patch including the 2 and 3 patch modifications.

farfanfelipe’s picture

StatusFileSize
new1.4 KB
PASSED: [[SimpleTest]]: [MySQL] 55,748 pass(es).
[ View ]
SpartyDan’s picture

Status:Needs work» Needs review

changed status to needs review so the bot would test the patch in #6

oenie’s picture

Status:Needs review» Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new976 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,052 pass(es).
[ View ]

re-rolled

dawehner’s picture

Status:Needs review» Needs work

Another candidate for protected

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new989 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,872 pass(es).
[ View ]

function changed to protected

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed ecbeb10 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.