Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#15 renamed-store-group-input-2003240-15.patch1.48 KBtheladebug
#11 renamed-store-group-input-2003240-11.patch1.48 KBtheladebug
#4 drupal-store-group-input-2003240-2.patch1.48 KBgdf
#3 drupal-store-group-input-2003240-1.patch1.48 KBgdf
#2 drupal-store-group-input-2003240.patch1.47 KBgdf

Comments

gdf’s picture

gdf commented
Assigned: Unassigned » gdf
gdf’s picture

gdf commented
Status: Active » Needs review
StatusFileSize
new drupal-store-group-input-2003240.patch1.47 KB
gdf’s picture

gdf commented
StatusFileSize
new drupal-store-group-input-2003240-1.patch1.48 KB

forgot to add "public" to method

gdf’s picture

gdf commented
StatusFileSize
new drupal-store-group-input-2003240-2.patch1.48 KB

changed "publi" to "public", note to myself not to borrow cheesy mac from friend next DrupalCon

munizjor’s picture

munizjor commented
Status: Needs review » Reviewed & tested by the community

Ran successful test creating a view.

pbuyle’s picture

pbuyle commented

I did not find any occurrence of the store_group_input in core after applying the patch in #4.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-store-group-input-2003240-2.patch, failed testing.

pbuyle’s picture

pbuyle commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#4: drupal-store-group-input-2003240-2.patch queued for re-testing.

gdf’s picture

gdf commented
Assigned: gdf » Unassigned

retest was successful - code is not related, and it was a very, very busy day for testBot

oenie’s picture

oenie commented
Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

theladebug’s picture

theladebug commented
Status: Needs work » Needs review
StatusFileSize
new renamed-store-group-input-2003240-11.patch1.48 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, renamed-store-group-input-2003240-11.patch, failed testing.

theladebug’s picture

theladebug commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#11: renamed-store-group-input-2003240-11.patch queued for re-testing.

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

You need to reroll your patch i don't think it applies anymore. (due to all the views patches getting in)

theladebug’s picture

theladebug commented
Status: Needs work » Needs review
StatusFileSize
new renamed-store-group-input-2003240-15.patch1.48 KB

rerolled patch

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5e0590c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.