Files: 
CommentFileSizeAuthor
#9 drupal_rename_summary_argument-2003238-9.patch4.77 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 56,009 pass(es). View
#2 drupal.summary_argument-2003238.patch3.26 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 56,897 pass(es). View

Comments

nathangervais’s picture

Assigned: Unassigned » nathangervais
nathangervais’s picture

Status: Active » Needs review
FileSize
3.26 KB
PASSED: [[SimpleTest]]: [MySQL] 56,897 pass(es). View
craychee’s picture

Status: Needs review » Reviewed & tested by the community

Adds public. All functions changed. Nice work.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal.summary_argument-2003238.patch, failed testing.

nathangervais’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal.summary_argument-2003238.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Needs work

Hate to throw this back, but it seems some replacements have been missed:

core/modules/views/views.theme.inc, line 436:
$row_args[$id] = $argument->summary_argument($row);

core/modules/views/views.theme.inc, line 496:
$row_args[$id] = $argument->summary_argument($row);

nathangervais’s picture

Status: Needs work » Needs review
FileSize
4.77 KB
PASSED: [[SimpleTest]]: [MySQL] 56,009 pass(es). View

Right your are, appears my search missed that file, i've rerolled the patch from the latest HEAD, and also updated a comment referring to summary_argument.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f6ea9cd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.