Files: 
CommentFileSizeAuthor
#9 views-core-value-submit-2003236-09.patch3.15 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,182 pass(es). View
#6 views-valueSubmit-2003236-6.patch3.13 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 57,710 pass(es). View
#2 drupal-rename-value-submit-2003236-2.patch3.1 KBkenianbei
FAILED: [[SimpleTest]]: [MySQL] Setup environment: failed to clear checkout directory. View

Comments

kenianbei’s picture

Assigned: Unassigned » kenianbei
kenianbei’s picture

Status: Active » Needs review
FileSize
3.1 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: failed to clear checkout directory. View

Status: Needs review » Needs work

The last submitted patch, drupal-rename-value-submit-2003236-2.patch, failed testing.

SpartyDan’s picture

@kenianbei - It looks like you should resubmit your patch.

The failure message was: Setup environment - The testbot client is probably malfunctioning.

Your patch looks good to me.

aspilicious’s picture

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.phpundefined
@@ -330,7 +330,7 @@ function validate_term_strings(&$form, $values) {
+  function valueSubmit($form, &$form_state) {

should be public function valueSubmit (in all cases)

zschmid’s picture

FileSize
3.13 KB
PASSED: [[SimpleTest]]: [MySQL] 57,710 pass(es). View

updated patch

zschmid’s picture

Status: Needs work » Needs review
aspilicious’s picture

Status: Needs review » Needs work

Looking at this again, this should be protected :s. Srry!
The function is only used internally by filter plugins.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
3.15 KB
PASSED: [[SimpleTest]]: [MySQL] 57,182 pass(es). View

functions changed to protected

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c93be24 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.