Looks like a copy/paste error from summary_name - LanguageArgument.php line 37.

CommentFileSizeAuthor
#9 drupal-incorrect-comment-2003210-9.patch740 byteshussainweb
#2 vdc-2003210.patch735 bytesjastraat

Comments

jastraat’s picture

jastraat commented
Issue tags: +Novice, +VDC

adding tags

jastraat’s picture

jastraat commented
Status: Active » Needs review
StatusFileSize
new vdc-2003210.patch735 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Looks good, thanks! I'll try to get it committed soon.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

This patch no longer applies; it needs a quick re-roll. Asking for a re-test.

dries’s picture

dries commented
Status: Needs work » Needs review
Issue tags: -Novice, -VDC

#2: vdc-2003210.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, vdc-2003210.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: +Needs reroll

tagging

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal-incorrect-comment-2003210-9.patch740 bytes

Here is the rerolled patch. It looks the same as far as I could see but I walked through the changes here and everything worked fine. Let me know if I am missing something.

UPDATE: I see the changes. Never mind my comment above. This patch should work against latest tree.

linl’s picture

linl commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice find!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.