Looks like a copy/paste error from summary_name - LanguageArgument.php line 37.

CommentFileSizeAuthor
#9 drupal-incorrect-comment-2003210-9.patch740 byteshussainweb
PASSED: [[SimpleTest]]: [MySQL] 57,667 pass(es). View
#2 vdc-2003210.patch735 bytesjastraat
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-2003210.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

jastraat’s picture

Issue tags: +Novice, +VDC

adding tags

jastraat’s picture

Status: Active » Needs review
FileSize
735 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-2003210.patch. Unable to apply patch. See the log in the details link for more information. View
jhodgdon’s picture

Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Looks good, thanks! I'll try to get it committed soon.

Dries’s picture

Status: Reviewed & tested by the community » Needs work

This patch no longer applies; it needs a quick re-roll. Asking for a re-test.

Dries’s picture

Status: Needs work » Needs review
Issue tags: -Novice, -VDC

#2: vdc-2003210.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, vdc-2003210.patch, failed testing.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
jhodgdon’s picture

Issue tags: +Needs reroll

tagging

hussainweb’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
740 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,667 pass(es). View

Here is the rerolled patch. It looks the same as far as I could see but I walked through the changes here and everything worked fine. Let me know if I am missing something.

UPDATE: I see the changes. Never mind my comment above. This patch should work against latest tree.

LinL’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice find!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.