Switch Views RSS to use Serializer/Zend

Missing the most important tag ;)

related #2025643: Add proxy services to Zend\Reader and Zend\Writer for better DX

How much do you think has to be done to at least allow maybe contrib to provide a proper implementation?

+++ b/core/modules/rest/lib/Drupal/rest/Plugin/views/style/Serializer.phpundefined
@@ -126,7 +127,15 @@ public function render() {
+    // @todo Use the real description.
+    $collection->setDescription('foobar');

The rss style plugined had a getDescription() method back in the days, not sure whether this is still the case. Maybe getting the collection should be moved to a separate method so it can be easily overridden in a subclass. I guess we need a subclass anyway ?

+++ b/core/modules/serialization/lib/Drupal/serialization/Tests/RssEntitySerializationTest.phpundefined
@@ -0,0 +1,58 @@
+class RssEntitySerializationTest extends DrupalUnitTestBase {

Is there a reason why this is not a unit test?

Maybe I just got confused because the test didn't added any kind of entity into the collection.

I'm guessing the fatal error is related to this:

diff --git a/core/modules/serialization/lib/Drupal/serialization/Tests/EntitySerializationTest.php b/core/modules/serialization/lib/Drupal/serialization/Tests/EntitySerializationTest.php
index 46ad0cc..63c36ff 100644
--- a/core/modules/serialization/lib/Drupal/serialization/Tests/EntitySerializationTest.php
+++ b/core/modules/serialization/lib/Drupal/serialization/Tests/EntitySerializationTest.php
@@ -63,7 +63,7 @@ protected function setUp() {
     $this->entity = entity_create('entity_test_mulrev', $this->values);
     $this->entity->save();
 
-    $this->serializer = $this->container->get('serializer');
+    $this->serializer = $this->serializer;
 
     $this->installConfig(array('field'));
   }

Good plan Lin, I like the sound of that.

I don't think the committers would approve this for 8.0 at this point, but it feels 8.1-friendly. There's no functionality change, just changes to the internal implementation, which should be fine for 8.1.

Based on #16, moving this to Postponed. Also added a related issue: #2296885: Remove format_xml_elements().

The last patch for this issues is very old. So I write by now the changes that is need to update in code for update the last patch.

/core/modules/rest/lib/Drupal/rest/Plugin/views/style/Serializer.php
Has been moved to /core/modules/rest/src/Plugin/views/style/Serializer.php

/core/modules/rest/lib/Drupal/rest/Tests/Views/RssTest.php
Is a new file, currently exist similar but in deep diferent code /core/modules/taxonomy/tests/src/Functional/RssTest.php

/core/modules/serialization/lib/Drupal/serialization/Encoder/RssEncoder.php
/core/modules/serialization/lib/Drupal/serialization/EntityCollection.php
/core/modules/serialization/lib/Drupal/serialization/Tests/EntitySerializationTest.php
/core/modules/serialization/lib/Drupal/serialization/Tests/RssEntitySerializationTest.php
Is a New file. Now lib folter is missing for all modules it is a old structure.

/core/modules/serialization/serialization.services.yml
Needs update with new service for RssEncoder

/core/modules/system/tests/modules/entity_test/lib/Drupal/entity_test/Plugin/Core/Entity/EntityTest.php
Has been moved to /core/modules/system/tests/modules/entity_test/src/Entity/EntityTest.php

We may be deprecating our dependency on Laminas (formerly Zend) Feed; if so, this issue should be marked wontfix. Postponing for now on #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1.

We've deprecated the writer service - #2919215: Deprecate feed.bridge.writer. This would depend on the service so it looks like we won't do this. Updating status accordingly.