Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 drupal-rename-get-non-aggregates-2002966-4.patch962 bytesjerdavis
#2 drupal-rename-get-non-aggregates-2002966-2.patch952 byteskenianbei
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Assigned: Unassigned » kenianbei
kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Status: Active » Needs review
FileSize
drupal-rename-get-non-aggregates-2002966-2.patch952 bytes
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work

All occurrences replaced, but still issue stated below:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1148,7 +1148,7 @@ function build_condition($where = 'where') {
+  function getNonAggregates() {

Add protected access modifier in front of the function to adhere to the new OOP standards.

jerdavis’s picture

jerdavis
Location Minneapolis, MN
CreditAttribution: jerdavis commented
Status: Needs work » Needs review
FileSize
drupal-rename-get-non-aggregates-2002966-4.patch962 bytes

Re-roll for comments in #3

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 0d9ed85 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.