Files: 
CommentFileSizeAuthor
#4 drupal-rename-get-non-aggregates-2002966-4.patch962 bytesjerdavis
PASSED: [[SimpleTest]]: [MySQL] 55,814 pass(es).
[ View ]
#2 drupal-rename-get-non-aggregates-2002966-2.patch952 byteskenianbei
PASSED: [[SimpleTest]]: [MySQL] 55,926 pass(es).
[ View ]

Comments

kenianbei’s picture

Assigned:Unassigned» kenianbei
kenianbei’s picture

Status:Active» Needs review
StatusFileSize
new952 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,926 pass(es).
[ View ]
oenie’s picture

Status:Needs review» Needs work

All occurrences replaced, but still issue stated below:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1148,7 +1148,7 @@ function build_condition($where = 'where') {
+  function getNonAggregates() {

Add protected access modifier in front of the function to adhere to the new OOP standards.

jerdavis’s picture

Status:Needs work» Needs review
StatusFileSize
new962 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,814 pass(es).
[ View ]

Re-roll for comments in #3

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 0d9ed85 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.