Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | 2002952-18-update_page_info.patch | 2.24 KB | vito_a |
| #8 | 2002952-08-update_page_info.patch | 2.22 KB | tvlooy |
| #5 | 2002952-05-update_page_info.patch | 2.21 KB | SpartyDan |
| #2 | drupal-2002952.patch | 594 bytes | robert.laszlo |
Comments
Comment #1
robert.laszlo commentedComment #2
robert.laszlo commentedReady for testing.
Comment #3
robert.laszlo commentedComment #5
SpartyDan commentedNew patch that changes method name in 4 files in core.
Comment #7
elvis2 commentedPlease add an access modifier. For example, before your function name add "public", based on OOP standards.
Be sure to do that for all instances of "function updatePageInfo()".
Comment #8
tvlooy commentedAdded the access modifiers.
Comment #10
elvis2 commentedI think this might be a bogus error. Changing status to review to force the patch to tested.
Comment #11
aspilicious commented#8: 2002952-08-update_page_info.patch queued for re-testing.
Comment #12
dawehnerLooks great once it's green.
Comment #14
dawehner#8: 2002952-08-update_page_info.patch queued for re-testing.
Comment #16
elvis2 commented@tvlooy, sorry, this needs a re-roll. The core has changed enough that this patch will no longer apply. Re-pull the 8.x branch then try to re-roll the patch.
Comment #17
vito_a commentedComment #18
vito_a commentedRe-rolling the #8
Comment #19
vito_a commentedtagging
Comment #20
andyposttaggin
Comment #21
vito_a commentedComment #22
dawehnerComment #23
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #24
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.