Files: 
CommentFileSizeAuthor
#18 2002952-18-update_page_info.patch2.24 KBvito_a
PASSED: [[SimpleTest]]: [MySQL] 56,023 pass(es). View
#8 2002952-08-update_page_info.patch2.22 KBtvlooy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002952-08-update_page_info.patch. Unable to apply patch. See the log in the details link for more information. View
#5 2002952-05-update_page_info.patch2.21 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#2 drupal-2002952.patch594 bytesrobert.laszlo
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-2002952.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

robert.laszlo’s picture

Assigned: Unassigned » robert.laszlo
robert.laszlo’s picture

FileSize
594 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-2002952.patch. Unable to apply patch. See the log in the details link for more information. View

Ready for testing.

robert.laszlo’s picture

Assigned: robert.laszlo » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal-2002952.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
2.21 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

New patch that changes method name in 4 files in core.

Status: Needs review » Needs work

The last submitted patch, 2002952-05-update_page_info.patch, failed testing.

elvis2’s picture

Please add an access modifier. For example, before your function name add "public", based on OOP standards.

@@ -191,7 +191,7 @@ function execute_count_query(&$count_query) {
    * If there are pagers that need global values set, this method can
    * be used to set them. It will be called when the count query is run.
    */
-  function update_page_info() {
+  public function updatePageInfo() {
 
   }

Be sure to do that for all instances of "function updatePageInfo()".

tvlooy’s picture

Status: Needs work » Needs review
FileSize
2.22 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002952-08-update_page_info.patch. Unable to apply patch. See the log in the details link for more information. View

Added the access modifiers.

Status: Needs review » Needs work

The last submitted patch, 2002952-08-update_page_info.patch, failed testing.

elvis2’s picture

Status: Needs work » Needs review

I think this might be a bogus error. Changing status to review to force the patch to tested.

aspilicious’s picture

#8: 2002952-08-update_page_info.patch queued for re-testing.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Looks great once it's green.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002952-08-update_page_info.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

#8: 2002952-08-update_page_info.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 2002952-08-update_page_info.patch, failed testing.

elvis2’s picture

@tvlooy, sorry, this needs a re-roll. The core has changed enough that this patch will no longer apply. Re-pull the 8.x branch then try to re-roll the patch.

vito_a’s picture

Assigned: Unassigned » vito_a
vito_a’s picture

Status: Needs work » Needs review
FileSize
2.24 KB
PASSED: [[SimpleTest]]: [MySQL] 56,023 pass(es). View

Re-rolling the #8

vito_a’s picture

Issue tags: +CodeSprintUA

tagging

andypost’s picture

taggin

vito_a’s picture

Assigned: vito_a » Unassigned
dawehner’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Title: Rename Views method update_page_info() to updatePageInfo() » Change notice: Rename Views method update_page_info() to updatePageInfo()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

Title: Change notice: Rename Views method update_page_info() to updatePageInfo() » Rename Views method update_page_info() to updatePageInfo()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.