Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 drupal_rename_use_count_query-2002950-8.patch4 KBnathangervais
#4 2002950-chng-use_count_query-4.patch3.99 KBtvlooy
#2 2002950-chng-use_count_query.patch3.96 KBaprice42
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aprice42’s picture

aprice42 CreditAttribution: aprice42 commented
Assigned: Unassigned » aprice42
aprice42’s picture

aprice42 CreditAttribution: aprice42 commented
Status: Active » Needs review
FileSize
2002950-chng-use_count_query.patch3.96 KB

renamed all instances of "use_count_query".

Status: Needs review » Needs work

The last submitted patch, 2002950-chng-use_count_query.patch, failed testing.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Status: Needs work » Needs review
FileSize
2002950-chng-use_count_query-4.patch3.99 KB

Add access modifiers + re-test.

aprice42’s picture

aprice42 CreditAttribution: aprice42 commented
Assigned: aprice42 » Unassigned
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl https://drupal.org/files/2002950-chng-use_count_query-4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4081  100  4081    0     0   5127      0 --:--:-- --:--:-- --:--:--  6561
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php:1477
error: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php:141
error: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php: patch does not apply
nathangervais’s picture

nathangervais CreditAttribution: nathangervais commented
Status: Needs work » Needs review
FileSize
drupal_rename_use_count_query-2002950-8.patch4 KB

Rerolled patch against latest HEAD.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 802b6c0 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.