Files: 
CommentFileSizeAuthor
#8 drupal_rename_use_count_query-2002950-8.patch4 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,929 pass(es). View
#4 2002950-chng-use_count_query-4.patch3.99 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 56,953 pass(es). View
#2 2002950-chng-use_count_query.patch3.96 KBa_L_p
FAILED: [[SimpleTest]]: [MySQL] 55,702 pass(es), 1 fail(s), and 0 exception(s). View

Comments

a_L_p’s picture

Assigned: Unassigned » a_L_p
a_L_p’s picture

Status: Active » Needs review
FileSize
3.96 KB
FAILED: [[SimpleTest]]: [MySQL] 55,702 pass(es), 1 fail(s), and 0 exception(s). View

renamed all instances of "use_count_query".

Status: Needs review » Needs work

The last submitted patch, 2002950-chng-use_count_query.patch, failed testing.

tvlooy’s picture

Status: Needs work » Needs review
FileSize
3.99 KB
PASSED: [[SimpleTest]]: [MySQL] 56,953 pass(es). View

Add access modifiers + re-test.

a_L_p’s picture

Assigned: a_L_p » Unassigned
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl https://drupal.org/files/2002950-chng-use_count_query-4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4081  100  4081    0     0   5127      0 --:--:-- --:--:-- --:--:--  6561
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php:1477
error: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php:141
error: core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php: patch does not apply
nathangervais’s picture

Status: Needs work » Needs review
FileSize
4 KB
PASSED: [[SimpleTest]]: [MySQL] 55,929 pass(es). View

Rerolled patch against latest HEAD.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 802b6c0 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.