Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 drupal-rename-use_string_group_by-views-2002946-6.patch1.8 KBmariafromatoz
#5 drupal-rename-use_string_group_by-views-2002946-5.patch1.41 KBmariafromatoz
#2 drupal-rename-use_string_group_by-2002946-2.patch1.78 KBmalcomio

Comments

malcomio’s picture

malcomio commented
Assigned: Unassigned » malcomio
malcomio’s picture

malcomio commented
Status: Active » Needs review
StatusFileSize
new drupal-rename-use_string_group_by-2002946-2.patch1.78 KB

Status: Needs review » Needs work

The last submitted patch, drupal-rename-use_string_group_by-2002946-2.patch, failed testing.

aspilicious’s picture

aspilicious commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
+  function useStringGroupBy() {

Should be "public function useString..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
\ No newline at end of file

A file always need to end with a newline

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Needs review
StatusFileSize
new drupal-rename-use_string_group_by-views-2002946-5.patch1.41 KB
mariafromatoz’s picture

mariafromatoz commented
StatusFileSize
new drupal-rename-use_string_group_by-views-2002946-6.patch1.8 KB

Patch on #5 is incomplete, please see here a new patch with all the changes necessary.

oenie’s picture

oenie commented
Title: Rename Views method use_string_group_by() to useStringGroupBy() » Rename Views method lgtm() to useStringGroupBy()
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 89f15d2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.