Files: 
CommentFileSizeAuthor
#5 views-rename_views_method_uses_breadcrumb_to_usesBreadcrumb-2002944-5.patch1.49 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,195 pass(es).
[ View ]
#2 views-rename-uses-breadcrumb-2002944-2.patch1.48 KBsethviebrock
PASSED: [[SimpleTest]]: [MySQL] 55,893 pass(es).
[ View ]

Comments

sethviebrock’s picture

Assigned:Unassigned» sethviebrock
sethviebrock’s picture

Status:Active» Needs review
StatusFileSize
new1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 55,893 pass(es).
[ View ]
sethviebrock’s picture

Assigned:sethviebrock» Unassigned
aspilicious’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -91,7 +91,7 @@ function set_breadcrumb(&$breadcrumb) { }
+  function usesBreadcrumb() {

Should be "public function usesBreadcrumb"

JeroenT’s picture

Status:Needs work» Needs review
StatusFileSize
new1.49 KB
PASSED: [[SimpleTest]]: [MySQL] 57,195 pass(es).
[ View ]
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Committed bda0761 and pushed to 8.x. Thanks!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.