Files: 
CommentFileSizeAuthor
#8 views_rename_uses_tokens-2002938-8.patch741 bytesnathangervais
PASSED: [[SimpleTest]]: [MySQL] 56,085 pass(es).
[ View ]
#2 views-rename_uses_tokens_function-2002938-2.patch734 bytesvuzzbox
FAILED: [[SimpleTest]]: [MySQL] 55,924 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

vuzzbox’s picture

Assigned:Unassigned» vuzzbox

Working on this at 2013 DrupalCon "getting involved sprint." Wish me luck.

vuzzbox’s picture

StatusFileSize
new734 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,924 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

renamed function uses_tokens to usesTokens

vuzzbox’s picture

Status:Active» Needs review

Ready for review.

Status:Needs review» Needs work

The last submitted patch, views-rename_uses_tokens_function-2002938-2.patch, failed testing.

aspilicious’s picture

Strange seams like a random fail...
Can you please prepend the function with public "public function usesTokens".

Thnx!

vuzzbox’s picture

Status:Needs work» Needs review

I think all tests would be failing randomly because of an issue in a block positioning test not related to this (or many other issues). that test is failing randomly, but a patch was posted to fix it. See this issue: http://drupal.org/node/1987952#comment-7454266

Once that is fixed, this should pass.

aspilicious’s picture

Status:Needs review» Needs work

yeah but you still need tyo prepend the function with "public".
Views has realy old code and adding the correct type is needed in this issue.

nathangervais’s picture

Assigned:vuzzbox» nathangervais
Status:Needs work» Needs review
StatusFileSize
new741 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,085 pass(es).
[ View ]

Rerolled Patch with public modifier.

dawehner’s picture

This function is not used at all. I have the feeling that this is just wrong.

aspilicious’s picture

Should we remove it?

heddn’s picture

Should we convert it for now and create a follow-up to decide if it should be removed.

vuzzbox’s picture

I noticed this, too, no instances of this function being called.

Is it possible that it's being used by contrib modules? Is it possible to determine which contrib modules might be calling any given core function?

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Let's not remove code for now, as there might be contrib modules requiring this.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed ad6858d and pushed to 8.x. Thanks!

So can so do a scan of contrib to see if this is used...

Automatically closed -- issue fixed for 2 weeks with no activity.