Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Working on this at 2013 DrupalCon "getting involved sprint." Wish me luck.
renamed function uses_tokens to usesTokens
Ready for review.
The last submitted patch, views-rename_uses_tokens_function-2002938-2.patch, failed testing.
Strange seams like a random fail...
Can you please prepend the function with public "public function usesTokens".
I think all tests would be failing randomly because of an issue in a block positioning test not related to this (or many other issues). that test is failing randomly, but a patch was posted to fix it. See this issue: http://drupal.org/node/1987952#comment-7454266
Once that is fixed, this should pass.
yeah but you still need tyo prepend the function with "public".
Views has realy old code and adding the correct type is needed in this issue.
Rerolled Patch with public modifier.
This function is not used at all. I have the feeling that this is just wrong.
Should we remove it?
Should we convert it for now and create a follow-up to decide if it should be removed.
I noticed this, too, no instances of this function being called.
Is it possible that it's being used by contrib modules? Is it possible to determine which contrib modules might be calling any given core function?
Let's not remove code for now, as there might be contrib modules requiring this.
Committed ad6858d and pushed to 8.x. Thanks!
So can so do a scan of contrib to see if this is used...
Automatically closed -- issue fixed for 2 weeks with no activity.
Drupal is a registered trademark of Dries Buytaert.