Files: 
CommentFileSizeAuthor
#1 views-rename-methods-2002928-1.patch649 bytesbdone
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es).
[ View ]

Comments

bdone’s picture

Status:Active» Needs review
StatusFileSize
new649 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es).
[ View ]
marlatt’s picture

Status:Needs review» Reviewed & tested by the community

Confirmed no instances of old method remaining and contains public method assignment.

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Can't work out how this function would be called - is it necessary?

bdone’s picture

@alexpott: while core isn't yet, i believe StylePluginBase could potentially be used by contrib plugins that extend it.

perhaps someone from VDC can confirm that?

dawehner’s picture

Status:Needs work» Reviewed & tested by the community

By default the fields generated by the wizard will have no label, as it just looks silly.

The table style plugin removes that in the wizardSubmit method to show a label in the table header. That's just one
example why style plugins want to interfere with the wizard, so I would personally vote for keeping it in.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b2d4053 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.