Files: 
CommentFileSizeAuthor
#14 views_rename_getJoinData-2002924-14.patch2.41 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 56,487 pass(es).
[ View ]
#7 views_rename_getJoinData-2002924-7.patch2.64 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 56,036 pass(es).
[ View ]
#1 rename_get_join_data.2002924.1.patch2.41 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] 55,738 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

markie’s picture

Assigned:Unassigned» markie
Status:Active» Needs review
StatusFileSize
new2.41 KB
FAILED: [[SimpleTest]]: [MySQL] 55,738 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

patched

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename_get_join_data.2002924.1.patch, failed testing.

markie’s picture

Status:Needs work» Needs review

#1: rename_get_join_data.2002924.1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, rename_get_join_data.2002924.1.patch, failed testing.

oenie’s picture

Status:Needs work» Needs review
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -692,7 +692,7 @@ function adjust_join($join, $relationship) {
+  function getJoinData($table, $base_table) {

Add public access modifier in front of the function to adhere to the new OOP standards.

oenie’s picture

Status:Needs review» Needs work
markie’s picture

StatusFileSize
new2.64 KB
PASSED: [[SimpleTest]]: [MySQL] 56,036 pass(es).
[ View ]

added public

markie’s picture

Status:Needs work» Needs review

switch to needs review..

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views_rename_getJoinData-2002924-7.patch, failed testing.

markie’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -683,6 +683,7 @@ function adjust_join($join, $relationship) {
+   * @access public

Not sure I've seen this coding standard before. And looking at the function is appears it could be protected instead of public.

dawehner’s picture

There is at least one module reverse_node_reference which calls this method in a public context.

markie’s picture

Status:Needs work» Needs review
StatusFileSize
new2.41 KB
PASSED: [[SimpleTest]]: [MySQL] 56,487 pass(es).
[ View ]

I went ahead and removed the line, but I don't see the harm in declaring the functions access in the documentation. It is a valid docblock tag, and was suggested by PHPStorm. Actually, I don't see anything in the Drupal Coding Standards about function documentation..

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Thank you!

Well I don't see an advantage in using it, as @access doesn't really add additional information.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b58f444 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.