Rename Views method get_join_data() to getJoinData()

patched

#1: rename_get_join_data.2002924.1.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -692,7 +692,7 @@ function adjust_join($join, $relationship) {
+  function getJoinData($table, $base_table) {

Add public access modifier in front of the function to adhere to the new OOP standards.

added public

switch to needs review..

#7: views_rename_getJoinData-2002924-7.patch queued for re-testing.

Looks good to me now !

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -683,6 +683,7 @@ function adjust_join($join, $relationship) {
+   * @access public

Not sure I've seen this coding standard before. And looking at the function is appears it could be protected instead of public.

There is at least one module reverse_node_reference which calls this method in a public context.

I went ahead and removed the line, but I don't see the harm in declaring the functions access in the documentation. It is a valid docblock tag, and was suggested by PHPStorm. Actually, I don't see anything in the Drupal Coding Standards about function documentation..

Thank you!

Well I don't see an advantage in using it, as @access doesn't really add additional information.

Committed b58f444 and pushed to 8.x. Thanks!