Rename Views method get_field_alias() to getFieldAlias()

patched

#1: rename_getFieldAlias-2002912-1.patch queued for re-testing.

Patch queued for a retest, apart from problem below it should be in order.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1046,7 +1046,7 @@ function add_groupby($clause) {
+  function getFieldAlias($table_alias, $field) {

Add protected access modifier in front of the function to adher to the new OOP standards.

protected access added, but can you tell me why that function should be protected?

Sure. I'm going to assume you want to know the difference between the two ?
(You're a longtime Drupaller, so i'm not sure this is the right assumption, but anyway :))

Protected is used when methods are for internal use of an object and its subclasses.
In this case, you can see that the only code that calls it is $this->getFieldAlias.
Which would mean protected is enough for access.

This in contrast to code where you would see things like:

$this->query->getFieldAlias(...)

Here another class is calling the method on a different class. If you would write protected there, it would field a problem because the method is not visible to it. Public would be needed there.

Although it's not sure this mehod will always be called internally, i would always choose for the less visible one.
Unless of course it would be something more obvious (which this one doesn't feel like to me)

Hey thanks for the reply. I just wanted to hear your reasoning. Glad you went into detail.

Does everything look good?

Committed 5c63406 and pushed to 8.x. Thanks!