Rename Views method get_entity() to getEntity()

#2: views-Rename_Views_method_get_entity_to_getEntity-2002906-1.patch queued for re-testing.

#2: views-Rename_Views_method_get_entity_to_getEntity-2002906-1.patch queued for re-testing.

Test failure was random. ... though the patch needs a rerole.

This is a reroll of #2

You missed the one on core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php

Cool... i just ran a grep and grabbed a comment as well, looks like this should cover them all. Thanks!

patch looks good, #14: views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch queued for re-testing.

Thank you!

no problem. reviewed patch and good test result too. gtg with #14 views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch

Sorry, doesn't apply. :(

Reroll
Conflict

++<<<<<<< HEAD
 +    $vid = $this->getValue($values, 'node_vid');
 +    $node = $this->get_entity($values);
++=======
+     $vid = $this->get_value($values, 'node_vid');
+     $node = $this->getEntity($values);
++>>>>>>> 14

Resolved

 -    $vid = $this->get_value($values, 'node_vid');
 +    $vid = $this->getValue($values, 'node_vid');
-     $node = $this->get_entity($values);
+     $node = $this->getEntity($values);

Needs another reroll

curl https://drupal.org/files/2002906-20.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8487  100  8487    0     0   6940      0  0:00:01  0:00:01 --:--:--  8106
error: patch failed: core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php:112
error: core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php: patch does not apply
error: patch failed: core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php:644
error: core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php: patch does not apply

reroll

Let's try one more time.

#25: 2002906-25.patch queued for re-testing.

Re-roll

@pwieck
You touched a yml file and removed all renames, I don't think this will pass ;)

Re-roll. Made a nub mistake

@heddn sorry I'm new will try again

Re-re roll. I hope I got it this time.

Look at the first patches, this one doens't include everything

@aspilicious - I'm a nub. Just to get this straight next time. I take all the 'passed' patches apply them first them search for renames then make patch... Right? I don't want to keep wasting everyones time

@aspilicious - I just read the re-roll docs. Sorry. Will re-roll tonight

Reroll of comment #20

I can't seem to find a point in the commit that #20 works on. It keeps failing on RevisionLink.php. Started on June 4th and worked backwards till June 3rd. Am I doing something wrong?

#38: views-Rename_Views_method_get_entity_to_getEntity-2002906-38.patch queued for re-testing.

@pwieck I was able to apply #20 from commit 3a72626107fb906d41de73aed701ca5104a2c550

My last try at this re-roll

Holly Cow! #45 passed

i think this is OK now

Committed 2b51e78 and pushed to 8.x. Thanks!