Files: 
CommentFileSizeAuthor
#45 views-Rename_Views_method_get_entity_to_getEntity-2002906-45.patch8.31 KBpwieck
PASSED: [[SimpleTest]]: [MySQL] 57,418 pass(es). View
#38 views-Rename_Views_method_get_entity_to_getEntity-2002906-38.patch7.57 KBchrisguindon
FAILED: [[SimpleTest]]: [MySQL] 57,383 pass(es), 19 fail(s), and 0 exception(s). View
#34 views-Rename_Views_method_get_entity_to_getEntity-2002906-28.patch2.19 KBpwieck
FAILED: [[SimpleTest]]: [MySQL] 57,158 pass(es), 79 fail(s), and 5 exception(s). View
#31 views-Rename_Views_method_get_entity_to_getEntity-2002906-27.patch3.34 KBpwieck
FAILED: [[SimpleTest]]: [MySQL] 57,242 pass(es), 77 fail(s), and 0 exception(s). View
#29 views-Rename_Views_method_get_entity_to_getEntity-2002906-26.patch2.53 KBpwieck
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
#25 2002906-25.patch7.57 KBjibran
FAILED: [[SimpleTest]]: [MySQL] 57,317 pass(es), 19 fail(s), and 0 exception(s). View
#23 2002906-22.patch7.57 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002906-22.patch. Unable to apply patch. See the log in the details link for more information. View
#20 2002906-20.patch8.29 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,567 pass(es). View
#14 views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch8.29 KBaaronott
PASSED: [[SimpleTest]]: [MySQL] 55,928 pass(es). View
#14 views-Rename_Views_method_get_entity_to_getEntity-interdiff.txt1.29 KBaaronott
#12 views-Rename_Views_method_get_entity_to_getEntity-2002906-12_reroll.patch7.33 KBaaronott
PASSED: [[SimpleTest]]: [MySQL] 57,861 pass(es). View
#2 views-Rename_Views_method_get_entity_to_getEntity-2002906-1.patch7.38 KBchr.fritsch
FAILED: [[SimpleTest]]: [MySQL] 55,848 pass(es), 1 fail(s), and 0 exception(s). View

Comments

chr.fritsch’s picture

Assigned: Unassigned » chr.fritsch
chr.fritsch’s picture

Assigned: chr.fritsch » Unassigned
Status: Active » Needs review
FileSize
7.38 KB
FAILED: [[SimpleTest]]: [MySQL] 55,848 pass(es), 1 fail(s), and 0 exception(s). View

Status: Needs review » Needs work
a_L_p’s picture

Assigned: Unassigned » a_L_p
chr.fritsch’s picture

Status: Needs work » Needs review
a_L_p’s picture

Assigned: a_L_p » Unassigned

Status: Needs review » Needs work
Issue tags: -Novice, -VDC
jasonyarrington’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC
heddn’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Needs work
Issue tags: -VDC +Needs reroll

Test failure was random. ... though the patch needs a rerole.

aaronott’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
7.33 KB
PASSED: [[SimpleTest]]: [MySQL] 57,861 pass(es). View

This is a reroll of #2

dawehner’s picture

Status: Needs review » Needs work

You missed the one on core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php

aaronott’s picture

Status: Needs work » Needs review
FileSize
1.29 KB
8.29 KB
PASSED: [[SimpleTest]]: [MySQL] 55,928 pass(es). View

Cool... i just ran a grep and grabbed a comment as well, looks like this should cover them all. Thanks!

Status: Needs review » Needs work
Issue tags: -Novice
somepal’s picture

Status: Needs work » Needs review
Issue tags: +Novice
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you!

somepal’s picture

no problem. reviewed patch and good test result too. gtg with #14 views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, doesn't apply. :(

jibran’s picture

Status: Needs work » Needs review
Issue tags: +VDC
FileSize
8.29 KB
PASSED: [[SimpleTest]]: [MySQL] 56,567 pass(es). View

Reroll
Conflict

++<<<<<<< HEAD
 +    $vid = $this->getValue($values, 'node_vid');
 +    $node = $this->get_entity($values);
++=======
+     $vid = $this->get_value($values, 'node_vid');
+     $node = $this->getEntity($values);
++>>>>>>> 14

Resolved

 -    $vid = $this->get_value($values, 'node_vid');
 +    $vid = $this->getValue($values, 'node_vid');
-     $node = $this->get_entity($values);
+     $node = $this->getEntity($values);
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs another reroll

curl https://drupal.org/files/2002906-20.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8487  100  8487    0     0   6940      0  0:00:01  0:00:01 --:--:--  8106
error: patch failed: core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php:112
error: core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php: patch does not apply
error: patch failed: core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php:644
error: core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
7.57 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002906-22.patch. Unable to apply patch. See the log in the details link for more information. View

reroll

Status: Needs review » Needs work

The last submitted patch, 2002906-22.patch, failed testing.

jibran’s picture

Status: Needs work » Needs review
FileSize
7.57 KB
FAILED: [[SimpleTest]]: [MySQL] 57,317 pass(es), 19 fail(s), and 0 exception(s). View

Let's try one more time.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002906-25.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review

#25: 2002906-25.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 2002906-25.patch, failed testing.

pwieck’s picture

Status: Needs work » Needs review
FileSize
2.53 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Re-roll

dawehner’s picture

Status: Needs review » Needs work

@pwieck
You touched a yml file and removed all renames, I don't think this will pass ;)

pwieck’s picture

Status: Needs work » Needs review
FileSize
3.34 KB
FAILED: [[SimpleTest]]: [MySQL] 57,242 pass(es), 77 fail(s), and 0 exception(s). View

Re-roll. Made a nub mistake

heddn’s picture

Status: Needs review » Needs work

@pwieck, the patch #31 seems to be missing function renames that were included #20. And also, the scope of this issue is to simply rename the functions.

+++ b/core/modules/views/lib/Drupal/views/Tests/Entity/FieldEntityTest.php
@@ -19,7 +19,7 @@ class FieldEntityTest extends ViewTestBase {
+  public static $testViews = array('test_field_getEntity');

No need to rename variables, etc.

pwieck’s picture

@heddn sorry I'm new will try again

pwieck’s picture

Status: Needs work » Needs review
FileSize
2.19 KB
FAILED: [[SimpleTest]]: [MySQL] 57,158 pass(es), 79 fail(s), and 5 exception(s). View

Re-re roll. I hope I got it this time.

aspilicious’s picture

Status: Needs review » Needs work

Look at the first patches, this one doens't include everything

pwieck’s picture

@aspilicious - I'm a nub. Just to get this straight next time. I take all the 'passed' patches apply them first them search for renames then make patch... Right? I don't want to keep wasting everyones time

pwieck’s picture

@aspilicious - I just read the re-roll docs. Sorry. Will re-roll tonight

chrisguindon’s picture

FileSize
7.57 KB
FAILED: [[SimpleTest]]: [MySQL] 57,383 pass(es), 19 fail(s), and 0 exception(s). View

Reroll of comment #20

chrisguindon’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
pwieck’s picture

I can't seem to find a point in the commit that #20 works on. It keeps failing on RevisionLink.php. Started on June 4th and worked backwards till June 3rd. Am I doing something wrong?

chrisguindon’s picture

Status: Needs work » Needs review
chrisguindon’s picture

@pwieck I was able to apply #20 from commit 3a72626107fb906d41de73aed701ca5104a2c550

Status: Needs review » Needs work
pwieck’s picture

Status: Needs work » Needs review
FileSize
8.31 KB
PASSED: [[SimpleTest]]: [MySQL] 57,418 pass(es). View

My last try at this re-roll

pwieck’s picture

Holly Cow! #45 passed

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

i think this is OK now

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2b51e78 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.