Rename Views method get_current_page() to getCurrentPage()

Converts the get_current_page() function to getCurrentPage and adds the public decorator.

Adding public keyword to method.

Looks good

#4: 2002898-get_current_page-conversion_4.patch queued for re-testing.

#4: 2002898-get_current_page-conversion_4.patch queued for re-testing.

working on this

OK, so I'm pretty sure the patch in #4 is failing because while getCurrentPage was set correctly, the relevant test is also relying on setCurrentPage, which was only partially renamed. The related issue is #2003292: Rename Views method set_current_page() to setCurrentPage().

So just for the purposes of seeing if this will pass the test, I've changed all the references to setCurrentPage as well. I'm attaching an interdiff. If this passes, then #4 will likely pass once #2003292: Rename Views method set_current_page() to setCurrentPage() lands (although conversely that might fail until this one lands).

I am taking this.

I might need to change the setter as well, but want to try this.

Thank you. Yeah please not do both at the same time.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -103,7 +103,7 @@ function set_offset($offset) {
+  function getCurrentPage() {

Should be a public method.

yeah, sorry I missed that. here's the re-roll, made it public.

Thank you very much!

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.