Files: 
CommentFileSizeAuthor
#5 2002882-items-per-page-exposed-5.patch1.91 KBaspilicious
PASSED: [[SimpleTest]]: [MySQL] 56,981 pass(es).
[ View ]
#3 2002882-items-per-page-exposed-3.patch1.91 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 2002882-items-per-page-exposed-2.patch1.89 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

aspilicious’s picture

Assigned:Unassigned» aspilicious

Lets go!

aspilicious’s picture

Status:Active» Needs review
StatusFileSize
new1.89 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Done?

aspilicious’s picture

StatusFileSize
new1.91 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -249,7 +249,7 @@ function uses_exposed() {
+  public function itemsPerPageExposed() {

This can be set to protected instead of public.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new1.91 KB
PASSED: [[SimpleTest]]: [MySQL] 56,981 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002882-items-per-page-exposed-5.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 2002882-items-per-page-exposed-5.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed fb39ef6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.